Add rule to test for uninitialized pointers in derived types #299
+282
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Derived types can have non-saved default initializer values, and it is safest to ensure that pointers are associated, so that they can then be tested using intrinsics.
ZedThree
reviewed
Jan 17, 2025
| .map(|node| { | ||
| let var_name = node.to_text(src.source_text()).unwrap_or("").to_string(); | ||
|
|
||
| let init_var = format!("{var_name} => null()"); |
There was a problem hiding this comment.
This duplicates the variable name, see snapshot below:
20 |- integer, pointer :: pI1, pI2
20 |+ integer, pointer :: pI1pI1 => null(), pI2
Suggested change
| let init_var = format!("{var_name} => null()"); | |
| let init_var = format!(" => null()"); |
ZedThree
reviewed
Jan 17, 2025
| #[derive_message_formats] | ||
| fn message(&self) -> String { | ||
| let Self { var } = self; | ||
| format!("'{var}' does not have a default initialiser") |
There was a problem hiding this comment.
Maybe something more explicit:
Suggested change
| format!("'{var}' does not have a default initialiser") | |
| format!("pointer component '{var}' does not have a default initialiser") |
or is this too long-winded?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike normal variables in procedures, derived types can have non-saved default initializer values, and it is safest to ensure that pointers are associated, so that they can then be tested using intrinsics.
This is just the first type of variable to check in the derived types. Further checks can suggest default initializers on intrinsic typed variables.