Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add param include_watchonly for listSinceBlock rpc call #94

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add param include_watchonly for listSinceBlock rpc call #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/main/java/wf/bitcoin/javabitcoindrpcclient/BitcoinJSONRPCClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -517,6 +517,12 @@ public TransactionsSinceBlock listSinceBlock(String blockHash) throws GenericRpc
public TransactionsSinceBlock listSinceBlock(String blockHash, int targetConfirmations) throws GenericRpcException {
return new TransactionsSinceBlockImpl((Map<String, ?>) query("listsinceblock", blockHash, targetConfirmations));
}

@Override
@SuppressWarnings("unchecked")
public TransactionsSinceBlock listSinceBlock(String blockHash, int targetConfirmations, boolean includeWatchonly) throws GenericRpcException {
return new TransactionsSinceBlockImpl((Map<String, ?>) query("listsinceblock", blockHash, targetConfirmations, includeWatchonly));
}

@Override
@SuppressWarnings("unchecked")
Expand Down
13 changes: 13 additions & 0 deletions src/main/java/wf/bitcoin/javabitcoindrpcclient/BitcoindRpcClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -903,6 +903,19 @@ public interface BitcoindRpcClient {
* @see <a href="https://bitcoin.org/en/developer-reference#listsinceblock">listsinceblock</a>
*/
TransactionsSinceBlock listSinceBlock(String blockHash, int targetConfirmations) throws GenericRpcException;

/**
* The listsinceblock RPC gets all transactions affecting the wallet which have occurred since a particular block, plus the header hash of a block at a particular depth.
*
* @param blockHash The hash of a block header encoded as hex in RPC byte order.
* @param targetConfirmations Sets the lastblock field of the results to the header hash of a block with this many confirmations.
* @param includeWatchonly Include transactions to watch-only addresses.
*
* @return An object containing an array of transactions and the lastblock field
*
* @see <a href="https://bitcoin.org/en/developer-reference#listsinceblock">listsinceblock</a>
*/
TransactionsSinceBlock listSinceBlock(String blockHash, int targetConfirmations, boolean includeWatchonly) throws GenericRpcException;

/**
* The listtransactions RPC returns the most recent transactions that affect the wallet.
Expand Down