Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix recombinant filtering #480

Merged
merged 5 commits into from
Jun 8, 2023
Merged

Fix recombinant filtering #480

merged 5 commits into from
Jun 8, 2023

Conversation

GopiGugan
Copy link
Contributor

@GopiGugan
Copy link
Contributor Author

Need to update the test data to fix the cypress tests

@bonnielu
Copy link
Collaborator

bonnielu commented Jun 5, 2023

Some of the previous test files were specific to the test data files; I can update the tests to reflect the changes!

@GopiGugan
Copy link
Contributor Author

Some of the previous test files were specific to the test data files; I can update the tests to reflect the changes!

Thanks Bonnie, no worries. I can just add in the raw_lineage field to the previous data set for now.

@GopiGugan
Copy link
Contributor Author

Cypress tests pass locally now:

  (Run Finished)


       Spec                                              Tests  Passing  Failing  Pending  Skipped  
  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ ✔  beadplot.spec.cy.js                      00:20       10       10        -        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  covizu.spec.cy.js                        00:31       14       14        -        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  utils.spec.cy.js                         00:01        4        4        -        -        - │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘
    ✔  All specs passed!                        00:53       28       28        -        -        -  

@GopiGugan
Copy link
Contributor Author

Screenshot 2023-06-08 at 7 04 30 PM

Recombinants are being filtered correctly now

@GopiGugan GopiGugan merged commit 29d5723 into dev Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants