Skip to content

Keybindings for problem navigation #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 1, 2017
Merged

Keybindings for problem navigation #35

merged 11 commits into from
May 1, 2017

Conversation

spacerockzero
Copy link
Contributor

@spacerockzero spacerockzero commented Apr 30, 2017

Added

  • "Next problem" keybinding:
    META + RETURN / CTRL + ENTER

  • "Previous Problem" keybinding
    META + SHIFT + RETURN / CTRL + SHIFT + ENTER

  • META should also be whatever the META key is on your OS.
    (CMD for OSX, Windows key for Windows)

  • RETURN should be ENTER on Linux and Windows

Tested on:

OSX (10.12.4, 27" iMac)

  • Chrome 57
  • Firefox 53
  • Safari 10.1

iOS (iOS 10.3.1, iPhone 6 Plus )

  • mobile Safari 10.something
  • Mobile Chrome 58

Windows (Windows 10, Core 2 Quad Antique Gaming Rig)

  • Edge 14
  • IE11

Android (Nexus 10 Tablet, Android 5.1.1)

  • Chrome 57

Linux (Ubuntu 16, Core 2 Duo Antique Laptop)

  • Firefox 52
  • Chromium 57
  • Browser (User Agent says Chrome 53)

Temporary test-server

Can be tested at https://3ea02248.ngrok.io/ for a bit

@dllndv
Copy link

dllndv commented Apr 30, 2017

It would be better if the commands use ctrl on Linux and Windows. Using [windows key] + [Enter] feels weird.

@spacerockzero
Copy link
Contributor Author

It's the idea to use CTRL on linux/windows, I just didn't test that yet. Will get my windows and linux machines on the case asap.

@spacerockzero spacerockzero merged commit 0d44c55 into master May 1, 2017
@spacerockzero spacerockzero deleted the keybindings branch May 1, 2017 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants