Do not emit the DataCount section (WebAssembly#2010)

Its presence was causing validation errors in the Emscripten test suite. This should be reverted once the default feature set is no longer All.
PresleyHank · Apr 15, 2019 · cb2d635 · cb2d635
1 parent 1e91e1b
commit cb2d635
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 21 deletions.
diff --git a/src/wasm/wasm-binary.cpp b/src/wasm/wasm-binary.cpp
@@ -317,9 +317,14 @@ void WasmBinaryWriter::writeDataCount() {
   if (!wasm->features.hasBulkMemory() || !wasm->memory.segments.size()) {
     return;
   }
-  auto start = startSection(BinaryConsts::Section::DataCount);
-  o << U32LEB(wasm->memory.segments.size());
-  finishSection(start);
+
+  // TODO(tlively): re-enable writing the data count once the default feature
+  // set is no longer All, which causes validation errors in Emscripten due to
+  // the presence of an unrecognized section.
+
+  // auto start = startSection(BinaryConsts::Section::DataCount);
+  // o << U32LEB(wasm->memory.segments.size());
+  // finishSection(start);
 }
 
 void WasmBinaryWriter::writeDataSegments() {

diff --git a/test/debugInfo.fromasm.clamp.map b/test/debugInfo.fromasm.clamp.map
diff --git a/test/debugInfo.fromasm.map b/test/debugInfo.fromasm.map
diff --git a/test/unit/test_datacount.py b/test/unit/test_datacount.py