Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial enhancements #1

Merged
merged 4 commits into from
Feb 29, 2024

Conversation

darryncampbell-pubnub
Copy link
Collaborator

No description provided.

Copy link

netlify bot commented Feb 28, 2024

Deploy Preview for pubnub-transport-logistics ready!

Name Link
🔨 Latest commit 37a76a1
🔍 Latest deploy log https://app.netlify.com/sites/pubnub-transport-logistics/deploys/65e05b9167a53d0008d159f0
😎 Deploy Preview https://deploy-preview-1--pubnub-transport-logistics.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@darryncampbell-pubnub
Copy link
Collaborator Author

Review comments from @oliverfcarson:

  • When I hover over the vehicle or it's destination in the map, the pointer changes, as if I can click on them to reveal information or move them around. Trying to do this action doesn't do either - is something supposed to happen, such as coordinates popping up?
  • Is this demo going to be added as a new demo to /demos? There is wasted whitespace at the bottom of the demo page/below Registered Vehicles section for the desktop view, where perhaps you could put the Registered Vehicles section at, since the /demos page is quite narrow? I'm viewing this on a 24" monitor btw
  • When clicking on the edit button for a vehicle, I think you should include some info for Reboot Sensor/Redirect Vehicle, as initially I wasn't sure what those did w/o your explanation. Something like hover text I think is even fine!
  • Mobile view looks great

@darryncampbell-pubnub darryncampbell-pubnub merged commit cf90138 into main Feb 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant