Re-validate git url on changing git-type

PuneetPunamiya · Sep 9, 2021 · 3712547 · 3712547
1 parent 76ba1ae
commit 3712547
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/frontend/packages/dev-console/src/components/import/git/GitSection.tsx b/frontend/packages/dev-console/src/components/import/git/GitSection.tsx
@@ -144,7 +144,7 @@ const GitSection: React.FC<GitSectionProps> = ({
  name: nameTouched,
  application: { name: applicationNameTouched } = {},
  image: { selected: imageSelectorTouched } = {},
- git: { dir: gitDirTouched } = {},
+ git: { dir: gitDirTouched, type: gitTypeTouched } = {},
  } = touched;
  const { git: { url: gitUrlError } = {} } = errors;
 
@@ -313,7 +313,7 @@ const GitSection: React.FC<GitSectionProps> = ({
  setFieldValue('import.loadError', loadError);
  setFieldValue('import.strategies', importStrategies);
  if (importStrategies.length > 0) {
- values.formType !== 'edit' && setFieldValue('import.showEditImportStrategy', false);
+ setFieldValue('import.showEditImportStrategy', false);
  setFieldValue('import.selectedStrategy', importStrategies[0]);
  setFieldValue('import.recommendedStrategy', importStrategies[0]);
  } else {
@@ -324,7 +324,7 @@ const GitSection: React.FC<GitSectionProps> = ({
  detectedFiles: [],
  });
  setFieldValue('import.recommendedStrategy', null);
- values.formType !== 'edit' && setFieldValue('import.showEditImportStrategy', true);
+ setFieldValue('import.showEditImportStrategy', true);
  }
  setFieldValue('import.strategyChanged', false);
 
@@ -397,7 +397,7 @@ const GitSection: React.FC<GitSectionProps> = ({
  }, [debouncedHandleGitUrlChange, sampleRepo, setFieldTouched, setFieldValue, tag]);
 
  React.useEffect(() => {
- (!dirty || gitDirTouched || formReloadCount) &&
+ (!dirty || gitDirTouched || gitTypeTouched || formReloadCount) &&
  values.git.url &&
  debouncedHandleGitUrlChange(values.git.url, values.git.ref, values.git.dir);
  }, [
@@ -409,6 +409,8 @@ const GitSection: React.FC<GitSectionProps> = ({
  values.git.url,
  values.git.ref,
  values.git.dir,
+ values.git.type,
+ gitTypeTouched,
  ]);
 
  const helpText = React.useMemo(() => {