Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --exclude and --exclude-glob flags #2153

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

idofran
Copy link

@idofran idofran commented Jul 7, 2023

Both flake8 and black have --exclude flag which works the same as --skip-glob in isort.

This is highly confusing because --skip-glob isn't a real glob, and works using fnmatch.

aliasing --exclude to --skip-glob and creating new real glob option called --exclude-glob will make isort compatible with --exclude option in other utilities and add a new glob option if anyone really meant to use glob.

In my opinion, it is best to deprecate --skip-glob and replace it completely with --exclude, however I'm not sure what is the policy here for doing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant