Add --exclude and --exclude-glob flags #2153
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both flake8 and black have
--exclude
flag which works the same as--skip-glob
in isort.This is highly confusing because
--skip-glob
isn't a real glob, and works usingfnmatch
.aliasing
--exclude
to--skip-glob
and creating new real glob option called--exclude-glob
will makeisort
compatible with--exclude
option in other utilities and add a new glob option if anyone really meant to use glob.In my opinion, it is best to deprecate
--skip-glob
and replace it completely with--exclude
, however I'm not sure what is the policy here for doing it.