Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make interpolation order selectable and set linear as default #134

Merged
merged 2 commits into from
Apr 23, 2023
Merged

Make interpolation order selectable and set linear as default #134

merged 2 commits into from
Apr 23, 2023

Conversation

MarJMue
Copy link
Collaborator

@MarJMue MarJMue commented Apr 18, 2023

fixes #131

@MarJMue MarJMue requested a review from domna April 18, 2023 19:33
domna
domna reviewed Apr 19, 2023
View reviewed changes
src/elli/dispersions/table_epsilon.py Outdated Show resolved Hide resolved
src/elli/dispersions/table_index.py Outdated Show resolved Hide resolved
@MarJMue MarJMue force-pushed the selectable-interpolation-order branch from a1da833 to 4a08648 Compare April 19, 2023 07:18
@domna
Copy link
Member

domna commented Apr 19, 2023

Just one note. I think it's good to go but wouldn't fix #131 entirely, because using a user specified cubic would still fail the 2x2 solver. I think, however, it's fine to close and deal with the issue in #130.

@MarJMue
Copy link
Collaborator Author

MarJMue commented Apr 19, 2023

Defaults are important and with this it becomes unlikely, that some RII dispersion provokes the error from the fix of #130.

@MarJMue MarJMue merged commit 48e3b7d into master Apr 23, 2023
@MarJMue MarJMue deleted the selectable-interpolation-order branch April 23, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domna domna domna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tabular dispersions might break Solver2x2
2 participants
@MarJMue @domna