Add check for active medium in solver2x2 #136
Conversation
| @@ -55,6 +55,16 @@ def calculate(self) -> Result: | |||
| ) | |||
| ) | |||
|
|
|||
| for layer in n_list: | |||
| if np.any(np.logical_and(layer.real > 0, layer.imag < 0)): | |||
There was a problem hiding this comment.
Wouldn't n < 0 and k > 0 not also be allowed. I think we are fixed to work in n+ik, right? So we cannot easily switch signs and would interpret this as absorption + negative refractive index. Whether we can handle negative refractive index is the other question 😅. But maybe we should throw two distinct error messages for this case? One that it cannot handle active media and one that it cannot handle negative refractive indices?
Your decision, I would be happy with both solutions.
There was a problem hiding this comment.
I suppose you are right.
One other thing: Did we prefer an error or a warning?
There was a problem hiding this comment.
I think we never really discussed what it should be. We both assumed that it would be an error.
However, after thinking about it I think it might be better to make it a warning. My view here is that an error should only be thrown if the problem is unrecoverable and the program cannot continue with this value. This is not the case for us. Also I find it always harsh when I program quits with an error and typically it's nicer to get weird data + a warning which tells you how to resolve the problem.
There was a problem hiding this comment.
Btw, if you make it a warning. Do we want start using logging for this stuff?
I don't know if we have some other information we display somewhere, but I think we never really outputted a warning or so...
There was a problem hiding this comment.
Ok then we agree, a warning is best.
I never used logging, but the dedicated standard library is most of the time the best way to do something like this. I will read into it.
Maybe this is also a good way to print debugging information instead of wrinting printing statements into the code.
There was a problem hiding this comment.
I have decided to use the warning package for now, as long as we do not use any other logging features.
fixes #130