Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subgradient hub #487

Merged
merged 11 commits into from
Feb 18, 2025
Merged

Subgradient hub #487

merged 11 commits into from
Feb 18, 2025
+244 −31

Conversation

bknueven
Copy link
Collaborator

@bknueven bknueven commented Feb 4, 2025

No description provided.

@bknueven bknueven requested a review from DLWoodruff February 4, 2025 22:32
DLWoodruff
DLWoodruff approved these changes Feb 5, 2025
View reviewed changes
Copy link
Collaborator

@DLWoodruff DLWoodruff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everywhere there is just "sub" it would be good to go to "subgrad" or "sub_grad" ("sub" is just to heavily overloaded).

I am approving, but I don't completely understand, so maybe we can talk on Friday.

@bknueven bknueven marked this pull request as ready for review February 6, 2025 20:59
@bknueven
Copy link
Collaborator Author

Need to change the name of the option SUBGRAD to subgradient_hub or subgrad_hub or sub_hub.

@bknueven bknueven enabled auto-merge February 18, 2025 16:40
@bknueven bknueven merged commit 9413a74 into Pyomo:main Feb 18, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DLWoodruff DLWoodruff DLWoodruff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bknueven @DLWoodruff