Update Orchard version #103
Conversation
alexeykoren
commented
Mar 4, 2025
alexeykoren
commented
- Use new Orchard version
- Use new lifecycle of IssueBundle
.github/workflows/ci.yml
Outdated
| - name: Generate coverage report | ||
| run: > | ||
| cargo tarpaulin | ||
| cargo +1.71.0 tarpaulin |
There was a problem hiding this comment.
can you explain the changes to this file?
There was a problem hiding this comment.
It seems that GitHub action runners have been updated and no longer have 1.71.0 toolchain by default. So we need to install it manually. But here specifically we probably don't need it because cargo will pick it up from toolchain.toml
| @@ -972,6 +975,7 @@ impl<'a, P: consensus::Parameters, U: sapling::builder::ProverProgress> Builder< | |||
| #[cfg(zcash_unstable = "nu6" /* TODO nu7 */ )] | |||
| let issue_bundle = unauthed_tx | |||
| .issue_bundle | |||
| .map(|b| b.update_rho(first_nullifier(&orchard_bundle).unwrap())) | |||
There was a problem hiding this comment.
what's the point of Result<> if we don't check it?
There was a problem hiding this comment.
Not so much indeed, Error scenario is extremely unlikely here, so we can simplify the flow to just panic inside the function in few extremely rare situation
| match orchard_bundle { | ||
| Some(OrchardBundle::OrchardVanilla(_)) => Err(io::Error::new( | ||
| io::ErrorKind::Other, | ||
| "Incorrect bundle type", |
There was a problem hiding this comment.
the function is named first_nullifier, why block it for Vanilla?
There was a problem hiding this comment.
It is only relevant for ZSA/Swap, in case of Vanilla you never call this method and if you managed somehow - it will just panic
