Skip to content

Commit

Permalink
Add few reference notes in debbuild readme
Browse files Browse the repository at this point in the history
At the time of doing patch release v0.25.1, the build at launchpad
failed with the error

```
+ cat debian/VERSION
+ VERSION=0.25.1
+ go build -mod=vendor -v -o obj-x86_64-linux-gnu/bin/tkn -ldflags -X github.com/tektoncd/cli/pkg/cmd/version.clientVersion=0.25.1 ./cmd/tkn
build flag -mod=vendor only valid when using modules
make[1]: *** [debian/rules:17: override_dh_auto_build] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:14: build] Error 2
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2
--------------------------------------------------------------------------------
```

So adding the notes in Readme for future reference.

Signed-off-by: vinamra28 <[email protected]>
  • Loading branch information
vinamra28 authored and tekton-robot committed Nov 7, 2022
1 parent 113ba4c commit a9a6263
Showing 1 changed file with 20 additions and 4 deletions.
24 changes: 20 additions & 4 deletions tekton/debbuild/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,13 @@

* First you need to join the launchpad team here :

https://launchpad.net/~tektoncd/+join
https://launchpad.net/~tektoncd/+join

* You need to make sure you upload your GPG key to your launchpad profile, ie:

https://launchpad.net/~chmouel/+editpgpkeys
https://launchpad.net/~chmouel/+editpgpkeys


(replace chmouel by your user)
(replace chmouel by your user)

* add an environment variable called GPG_KEY with your GPG key user ID

Expand All @@ -20,3 +19,20 @@
* It should upload to
https://launchpad.net/~tektoncd/+archive/ubuntu/cli/+packages you can inspect
the build logs in there in case of failure.

- **Note**: There can be a case when the uploaded build fails on launchpad with the below error:

```
+ go build -mod=vendor -v -o obj-x86_64-linux-gnu/bin/tkn -ldflags -X github.com/tektoncd/cli/pkg/cmd/version.clientVersion=0.25.1 ./cmd/tkn
build flag -mod=vendor only valid when using modules
make[1]: *** [debian/rules:17: override_dh_auto_build] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:14: build] Error 2
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2
--------------------------------------------------------------------------------
```

In this case, edit the [rules](./control//rules) file. Try appending `GO111MODULE=on` at Line #20.

- **Note**: If the first build fails, then in order to repush the new build, increment the release
version in [buildpackage.sh](./container/buildpackage.sh) at Line #6

0 comments on commit a9a6263

Please sign in to comment.