other

QiXi · Sep 23, 2021 · 359951b · 359951b
1 parent 0a75056
commit 359951b
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 6 deletions.
diff --git a/lib/src/batch/batch_data.dart b/lib/src/batch/batch_data.dart
@@ -30,6 +30,7 @@ class BatchData {
   }
 
   void fillOneUnit(Float32List rstTransforms, Float32List rect, int color, [int skipCount = 0]) {
+    //TODO performance
     final index0 = currentIndex;
     rawTransforms.setRange(index0, index0 + 4, rstTransforms, skipCount);
     rawSources.setRange(index0, index0 + 4, rect, skipCount);

diff --git a/lib/src/components/text_component.dart b/lib/src/components/text_component.dart
@@ -11,7 +11,7 @@ class TextComponent extends Component with Dirty {
   );
   final TextPainter _textPainter;
   final DrawableText _drawable;
-  var _textStyle;
+  final TextStyle _textStyle;
   String _text;
 
   TextComponent(this._text, RenderComponent renderComponent, {TextStyle? style})

diff --git a/lib/src/core/object_manager.dart b/lib/src/core/object_manager.dart
@@ -57,6 +57,8 @@ class ObjectManager<T extends BaseObject> extends BaseObject {
 
   List<T> getAdditionsArray() => _pendingAdditions;
 
+  List<T> getRemovalsArray() => _pendingRemovals;
+
   void add(T object) {
     _pendingAdditions.add(object);
   }
@@ -80,14 +82,13 @@ class ObjectManager<T extends BaseObject> extends BaseObject {
   }
 
   E? _findByType<E extends BaseObject>(List<T> _objectArray) {
-    final count = _objectArray.length;
-    for (var i = 0; i < count; i++) {
+    final length = _objectArray.length;
+    for (var i = 0; i < length; i++) {
       var currentObject = _objectArray[i];
       if (currentObject.runtimeType == E) {
         return currentObject as E;
       }
     }
-    return null;
   }
 
   @override

diff --git a/lib/src/core/sorted_list.dart b/lib/src/core/sorted_list.dart
@@ -37,6 +37,7 @@ class SortedList<T> {
   }
 
   void sort(bool forceResort) {
+    //TODO performance
     if (!_sorted || forceResort) {
       if (_comparator != null) {
         data.sort(_comparator);

diff --git a/test/engine_test.dart b/test/engine_test.dart
@@ -7,11 +7,11 @@ import 'package:composition_rendering/batch.dart';
 import 'package:test/test.dart';
 
 void main() {
-  final defaultColor = 0xffffffff;
+  const defaultColor = 0xffffffff;
   test('EngineBatch.drawImage', () async {
     final image = await _createImage(1, 1);
     final bath = EngineBatch(capacity: 2);
-    bath.drawImageFromData(image, Rect.fromLTWH(0, 0, 1, 1), 1, 0, 0, 0, defaultColor);
+    bath.drawImageFromData(image, const Rect.fromLTWH(0, 0, 1, 1), 1, 0, 0, 0, defaultColor);
     expect(bath.rectCount, 1);
     expect(bath.freeLength, 4);
     var rawSprite = Float32List.fromList([1, 0, 10, 10, 1, 0, 20, 20, 1, 0, 30, 30]);