Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(input-image-name): default option for settings views #1778

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

RemiBonnet
Copy link
Member

What does this PR do?

https://qovery.atlassian.net/jira/software/projects/FRT/boards/23?selectedIssue=FRT-1387


PR Checklist

  • This PR introduces breaking change(s) and has been labeled as such
  • This PR introduces new store changes
  • I made sure the code is type safe (no any)

@RemiBonnet
Copy link
Member Author

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery preview cc1de7de-94e5-40f8-8e45-bc8986d9dfec storybook
/qovery preview 28c47145-c8e7-4b9d-8d9e-c65c95b48425 staging
/qovery preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI 🤖.
Below, a word from its wisdom :

Programs must be written for people to read, and only incidentally for machines to execute

@RemiBonnet RemiBonnet marked this pull request as ready for review December 5, 2024 13:32
Copy link

nx-cloud bot commented Dec 5, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit d5ace4c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

@RemiBonnet RemiBonnet changed the title fix(input-image-name): default option for setting view fix(input-image-name): default option for settings views Dec 5, 2024
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 53.44%. Comparing base (673c07a) to head (d5ace4c).
Report is 1 commits behind head on staging.

Files with missing lines Patch % Lines
...c/lib/general-container-settings/ui/image-name.tsx 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #1778      +/-   ##
===========================================
- Coverage    53.44%   53.44%   -0.01%     
===========================================
  Files          977      977              
  Lines        13369    13370       +1     
  Branches      3850     3851       +1     
===========================================
  Hits          7145     7145              
  Misses        4894     4894              
- Partials      1330     1331       +1     
Flag Coverage Δ
unittests 53.44% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RemiBonnet RemiBonnet merged commit ffeac65 into staging Dec 5, 2024
12 checks passed
@RemiBonnet RemiBonnet deleted the fix/container-image-search-setting-FRT-1387 branch December 5, 2024 13:40
@RemiBonnet
Copy link
Member Author

🎉 This PR is included in version 1.166.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant