Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deployment-logs): redirect lastest version id and dark mode modal redeploy #1788

Merged
merged 6 commits into from
Dec 12, 2024

Conversation

RemiBonnet
Copy link
Member

@RemiBonnet RemiBonnet commented Dec 12, 2024

What does this PR do?

  • Add versionId for each deployment logs even if it's the latest
    Note: If we pass version for websocket it works like REST API even if it's the latest deployment id / version id

  • Fix dark modal redeploy


PR Checklist

  • This PR introduces breaking change(s) and has been labeled as such
  • This PR introduces new store changes
  • I made sure the code is type safe (no any)

@RemiBonnet
Copy link
Member Author

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery preview cc1de7de-94e5-40f8-8e45-bc8986d9dfec storybook
/qovery preview 28c47145-c8e7-4b9d-8d9e-c65c95b48425 staging
/qovery preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI 🤖.
Below, a word from its wisdom :

Programs must be written for people to read, and only incidentally for machines to execute

Copy link

nx-cloud bot commented Dec 12, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 11c4720. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

@RemiBonnet RemiBonnet marked this pull request as ready for review December 12, 2024 17:06
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 37.03704% with 17 lines in your changes missing coverage. Please review.

Project coverage is 53.40%. Comparing base (e1165cb) to head (11c4720).
Report is 1 commits behind head on staging.

Files with missing lines Patch % Lines
.../pages/layout/src/lib/ui/breadcrumb/breadcrumb.tsx 0.00% 5 Missing and 2 partials ⚠️
...logs/environment/src/lib/page-environment-logs.tsx 37.50% 3 Missing and 2 partials ⚠️
...b/hooks/use-deployment-logs/use-deployment-logs.ts 0.00% 3 Missing ⚠️
.../lib/list-deployment-logs/list-deployment-logs.tsx 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #1788      +/-   ##
===========================================
- Coverage    53.50%   53.40%   -0.11%     
===========================================
  Files          995      957      -38     
  Lines        13664    13057     -607     
  Branches      3938     3800     -138     
===========================================
- Hits          7311     6973     -338     
+ Misses        4987     4781     -206     
+ Partials      1366     1303      -63     
Flag Coverage Δ
unittests 53.40% <37.03%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RemiBonnet RemiBonnet changed the title fix(deployment-logs): redirect last version id if no id + memoized data fix(deployment-logs): redirect lastest version id and dark mode modal redeploy Dec 12, 2024
@RemiBonnet RemiBonnet merged commit 685a6f4 into staging Dec 12, 2024
12 checks passed
@RemiBonnet RemiBonnet deleted the fix/deployment-logs-redirection branch December 12, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant