Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(environment-service-actions): add deployment logs link in toasts #1790

Merged
merged 5 commits into from
Dec 17, 2024

Conversation

RemiBonnet
Copy link
Member

What does this PR do?

https://qovery.atlassian.net/jira/software/projects/FRT/boards/23?selectedIssue=FRT-1375


PR Checklist

  • This PR introduces breaking change(s) and has been labeled as such
  • This PR introduces new store changes
  • I made sure the code is type safe (no any)

@RemiBonnet RemiBonnet marked this pull request as ready for review December 16, 2024 16:45
Base automatically changed from feat/new-deployment-banner-FRT-1380 to staging December 17, 2024 12:56
@RemiBonnet RemiBonnet force-pushed the feat/add-link-logs-toast-FRT-1375 branch from 6a24b92 to b73418d Compare December 17, 2024 12:57
@RemiBonnet RemiBonnet changed the title feat(deployment-actions): add deployment logs link in toasts for environment and service feat(environment-service-actions): add deployment logs link in toasts Dec 17, 2024
Copy link

nx-cloud bot commented Dec 17, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b90fab0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 62.96296% with 20 lines in your changes missing coverage. Please review.

Project coverage is 53.35%. Comparing base (f7c57cb) to head (b90fab0).
Report is 1 commits behind head on staging.

Files with missing lines Patch % Lines
...hooks/use-stop-environment/use-stop-environment.ts 33.33% 1 Missing and 1 partial ⚠️
...src/lib/hooks/use-edit-service/use-edit-service.ts 0.00% 2 Missing ⚠️
...b/hooks/use-restart-service/use-restart-service.ts 33.33% 1 Missing and 1 partial ⚠️
...src/lib/hooks/use-stop-service/use-stop-service.ts 33.33% 1 Missing and 1 partial ⚠️
...rking-feature/page-settings-networking-feature.tsx 0.00% 2 Missing ⚠️
...age-settings-values-override-arguments-feature.tsx 0.00% 2 Missing ⚠️
...logs/environment/src/lib/page-environment-logs.tsx 0.00% 2 Missing ⚠️
...lib/hooks/use-deploy-service/use-deploy-service.ts 66.66% 1 Missing ⚠️
...eature/src/lib/service-details/service-details.tsx 0.00% 1 Missing ⚠️
...-domains-feature/page-settings-domains-feature.tsx 0.00% 0 Missing and 1 partial ⚠️
... and 3 more
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #1790      +/-   ##
===========================================
- Coverage    53.37%   53.35%   -0.02%     
===========================================
  Files          957      954       -3     
  Lines        13078    13081       +3     
  Branches      3812     3816       +4     
===========================================
- Hits          6980     6979       -1     
- Misses        4793     4794       +1     
- Partials      1305     1308       +3     
Flag Coverage Δ
unittests 53.35% <62.96%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RemiBonnet RemiBonnet merged commit 31e77fa into staging Dec 17, 2024
12 checks passed
@RemiBonnet RemiBonnet deleted the feat/add-link-logs-toast-FRT-1375 branch December 17, 2024 13:12
@RemiBonnet
Copy link
Member Author

🎉 This PR is included in version 1.169.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant