Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(creation-flow-database): default container value if cloud provider is GCP or SCW #1798

Merged
merged 2 commits into from
Dec 23, 2024

Conversation

RemiBonnet
Copy link
Member

What does this PR do?

https://qovery.atlassian.net/jira/software/projects/FRT/boards/23?selectedIssue=FRT-1394


PR Checklist

  • This PR introduces breaking change(s) and has been labeled as such
  • This PR introduces new store changes
  • I made sure the code is type safe (no any)

@RemiBonnet
Copy link
Member Author

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery preview cc1de7de-94e5-40f8-8e45-bc8986d9dfec storybook
/qovery preview 28c47145-c8e7-4b9d-8d9e-c65c95b48425 staging
/qovery preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI 🤖.
Below, a word from its wisdom :

Write comments that add new information that doesn’t exist in the code

@RemiBonnet RemiBonnet marked this pull request as ready for review December 23, 2024 15:06
Copy link

nx-cloud bot commented Dec 23, 2024

View your CI Pipeline Execution ↗ for commit e3804a9.

Command Status Duration Result
nx affected --target=test --parallel=3 --config... ✅ Succeeded 1m 35s View ↗
nx affected --target=build --parallel=3 ✅ Succeeded 1m 16s View ↗
nx affected --target=lint --parallel=3 ✅ Succeeded 13s View ↗
nx-cloud record -- npx nx format:check ✅ Succeeded 13s View ↗

☁️ Nx Cloud last updated this comment at 2024-12-23 15:13:25 UTC

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 51.60%. Comparing base (d481776) to head (e3804a9).
Report is 1 commits behind head on staging.

Files with missing lines Patch % Lines
...ture/step-general-feature/step-general-feature.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #1798      +/-   ##
===========================================
- Coverage    53.45%   51.60%   -1.85%     
===========================================
  Files          982      120     -862     
  Lines        13513     2616   -10897     
  Branches      3916      764    -3152     
===========================================
- Hits          7223     1350    -5873     
+ Misses        4937      985    -3952     
+ Partials      1353      281    -1072     
Flag Coverage Δ
unittests 51.60% <0.00%> (-1.85%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RemiBonnet RemiBonnet merged commit c0a1910 into staging Dec 23, 2024
11 of 12 checks passed
@RemiBonnet RemiBonnet deleted the fix/creation-flow-db-container-FRT-1384 branch December 23, 2024 15:14
@RemiBonnet
Copy link
Member Author

🎉 This PR is included in version 1.171.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant