Return long value when under min int value from IntFilter

Quiq · Aug 30, 2022 · 6cfcea0 · 6cfcea0
1 parent 0d8ebee
commit 6cfcea0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/main/java/com/hubspot/jinjava/lib/filter/IntFilter.java b/src/main/java/com/hubspot/jinjava/lib/filter/IntFilter.java
@@ -74,7 +74,7 @@ public Object filter(Object var, JinjavaInterpreter interpreter, String... args)
   }
 
   private Object convertResult(Long result) {
-    if (result > Integer.MAX_VALUE) {
+    if (result < Integer.MIN_VALUE || result > Integer.MAX_VALUE) {
       return result;
     }
     return result.intValue();

diff --git a/src/test/java/com/hubspot/jinjava/lib/filter/IntFilterTest.java b/src/test/java/com/hubspot/jinjava/lib/filter/IntFilterTest.java
@@ -124,6 +124,11 @@ public void itUsesLongsForLargeValueDefaults() {
       .isEqualTo(1000000000001L);
   }
 
+  @Test
+  public void itUsesLongsForVerySmallValues() {
+    assertThat(filter.filter("-42595200000", interpreter)).isEqualTo(-42595200000L);
+  }
+
   @Test
   public void itConvertsProperlyInExpressionTest() {
     assertThat(interpreter.render("{{ '3'|int in [null, 4, 5, 6, null, 3] }}"))