BathNorm tune API #3646
Draft
BathNorm tune API #3646
+106
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanLichtnerAMD
approved these changes
Mar 21, 2025
| @@ -84,6 +84,8 @@ using hipblasLt_handle_ptr = MIOPEN_MANAGE_PTR(hipblasLtHandle_t, hipblasLtDestr | |||
|
|
|||
| struct MIOPEN_EXPORT Handle : miopenHandle | |||
| { | |||
| miopenTuningPolicy_t tuning_policy; | |||
There was a problem hiding this comment.
Should this be private since you have getters and setters for this?
| miopenTuningPolicyNone = 1, /* do not enforce anything */ | ||
| miopenTuningPolicyDbUpdate = 2, /* do not load existing entry, do not tune */ | ||
| miopenTuningPolicySearch = 3, /* do not load existing entry, tune */ | ||
| miopenTuningPolicyDbClean = 5, /* remove existing entry, do not tune */ |
There was a problem hiding this comment.
I know you mentioned skipping SEARCH_DB_UPDATE, which corresponds to a 4, and was basically equivalent to miopenTuningPolicySearch. But doesn't this new api also apply to convolutions, so wouldn't we want to support SEARCH_DB_UPDATE in this api?
| miopenStatus_t miopenSetTuningPolicy(miopenHandle_t handle, miopenTuningPolicy_t newValue) | ||
| { | ||
| return miopen::try_([&] { | ||
| if(newValue < miopenTuningPolicyNone || newValue > miopenTuningPolicyDbClean) |
There was a problem hiding this comment.
Since this is an enum, the user could actually enter a 4 here. I assume this would just default to SEARCH_DB_UPDATE behaviour, but I wanted to double check...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the priorities for find enforce are:
This PR introduces TuningPolicy (this is the new thing)
This allows us to Tune from API.
miopenSetTuningPolicy(handle, miopenTuningPolicySearch); // set tuningmiopenBatchnorm...(...);miopenSetTuningPolicy(handle, miopenTuningPolicyNone); // unset tuningThis effect is not limited to bnorm.