Set of fixes for function signatures in derived classes that may (potentially) lead to logic bugs #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…base class one, or else it would never be called at all.
…ne, or else it would never be called at all.
… to avoid possible problems
…lass, also fix the default value of ClientCameraScript::startTarget to also match base class.
pkubanek
approved these changes
Sep 16, 2018
pkubanek
pushed a commit
that referenced
this pull request
Oct 23, 2018
…entially) lead to logic bugs (#35) * Fix the signature of CommandStatusInfo::commandReturnFailed to match base class one, or else it would never be called at all. * Fix the signature of SimbadTargetDb::printExtra to match base class one, or else it would never be called at all. * Fix the type used for vector * Fix the signature of Camera::checkQueChanges to match base class one, to avoid possible problems * Fix the signature of DevClientCameraExec::startTarget to match base class, also fix the default value of ClientCameraScript::startTarget to also match base class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several of derived classes have methods with signatures different from base virtual ones, for no obvious reason. Seems they will not be called as a result, that may lead to logic bugs somewhere.
Petr, please check whether these changes were intended, or just a mistakes