monitor: Use UTF-8 instead of ACS #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XePeleato
force-pushed
the
nmonitor-utf8
branch
from
c3e9061 to
47cd1ca
Compare
Some terminal emulators such as PuTTY or the macOS terminal don't have full VT100 ACS support. For this reason, the RTS2 monitor borders and lines are not rendered properly. Some applications rely on using directly the equivalent UTF-8 character, making sure the terminal supports UTF-8 encoding. This way, the monitor appareance is consistent between terminal emulators.
XePeleato
force-pushed
the
nmonitor-utf8
branch
from
47cd1ca to
0456dbd
Compare
pkubanek
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some terminal emulators, such as PuTTY or the macOS terminal, don't have full VT100 ACS support. For this reason, the RTS2 monitor borders and lines are not rendered properly.
Using the desired characters instead of ACS, we can render the monitor consistently for every terminal.
Here are some examples of the current monitor behaviour:
PuTTY:
macOS:
This is particularly confusing when editing a value or looking for something.
This is the behaviour using this patch:
PuTTY:
macOS:
