Just look at unsigned commits instead of looping through all commits …

…multiple times
Rakee08 · Mar 8, 2022 · 6eea364 · 6eea364
1 parent 7c448d4
commit 6eea364
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/.github/actions/verifySignedCommits/index.js b/.github/actions/verifySignedCommits/index.js
@@ -21,10 +21,9 @@ GitHubUtils.octokit.pulls.listCommits({
     pull_number: PR_NUMBER,
 })
     .then(({data}) => {
-        const allCommitsSigned = _.every(data, datum => datum.commit.verification.verified);
+        const unsignedCommits = _.filter(data, datum => !datum.commit.verification.verified);
 
-        if (!allCommitsSigned) {
-            const unsignedCommits = _.filter(data, datum => !datum.commit.verification.verified);
+        if (!_.isEmpty(unsignedCommits)) {
             const errorMessage = `Error: the following commits are unsigned: ${JSON.stringify(_.map(unsignedCommits, commitObj => commitObj.sha))}`;
             console.error(errorMessage);
             core.setFailed(errorMessage);

diff --git a/.github/actions/verifySignedCommits/verifySignedCommits.js b/.github/actions/verifySignedCommits/verifySignedCommits.js
@@ -11,10 +11,9 @@ GitHubUtils.octokit.pulls.listCommits({
     pull_number: PR_NUMBER,
 })
     .then(({data}) => {
-        const allCommitsSigned = _.every(data, datum => datum.commit.verification.verified);
+        const unsignedCommits = _.filter(data, datum => !datum.commit.verification.verified);
 
-        if (!allCommitsSigned) {
-            const unsignedCommits = _.filter(data, datum => !datum.commit.verification.verified);
+        if (!_.isEmpty(unsignedCommits)) {
             const errorMessage = `Error: the following commits are unsigned: ${JSON.stringify(_.map(unsignedCommits, commitObj => commitObj.sha))}`;
             console.error(errorMessage);
             core.setFailed(errorMessage);