Merge pull request Expensify#7287 from rushatgabhane/main

[No QA] Cleanup - Remove keyboard type numeric, and incorrect uses of phone-pad.
Rakee08 · Jan 18, 2022 · c330dcd · c330dcd
2 parents cda313d + 5c82654
commit c330dcd
Show file tree

Hide file tree

Showing 7 changed files with 7 additions and 8 deletions.
diff --git a/src/CONST.js b/src/CONST.js
@@ -341,7 +341,6 @@ const CONST = {
     },
 
     KEYBOARD_TYPE: {
-        NUMERIC: 'numeric',
         PHONE_PAD: 'phone-pad',
         NUMBER_PAD: 'number-pad',
     },

diff --git a/src/pages/ReimbursementAccount/AddressForm.js b/src/pages/ReimbursementAccount/AddressForm.js
@@ -79,7 +79,7 @@ const AddressForm = props => (
         <TextInput
             label={props.translate('common.zip')}
             containerStyles={[styles.mt4]}
-            keyboardType={CONST.KEYBOARD_TYPE.NUMERIC}
+            keyboardType={CONST.KEYBOARD_TYPE.NUMBER_PAD}
             value={props.values.zipCode}
             onChangeText={value => props.onFieldChange({zipCode: value})}
             errorText={props.errors.zipCode ? props.translate('bankAccount.error.zipCode') : ''}

diff --git a/src/pages/ReimbursementAccount/CompanyStep.js b/src/pages/ReimbursementAccount/CompanyStep.js
@@ -256,7 +256,7 @@ class CompanyStep extends React.Component {
                     <TextInput
                         label={this.props.translate('companyStep.taxIDNumber')}
                         containerStyles={[styles.mt4]}
-                        keyboardType={CONST.KEYBOARD_TYPE.NUMERIC}
+                        keyboardType={CONST.KEYBOARD_TYPE.NUMBER_PAD}
                         onChangeText={value => this.clearErrorAndSetValue('companyTaxID', value)}
                         value={this.state.companyTaxID}
                         disabled={shouldDisableCompanyTaxID}

diff --git a/src/pages/ReimbursementAccount/IdentityForm.js b/src/pages/ReimbursementAccount/IdentityForm.js
@@ -101,7 +101,7 @@ const IdentityForm = (props) => {
             <TextInput
                 label={`${props.translate('common.ssnLast4')}`}
                 containerStyles={[styles.mt4]}
-                keyboardType={CONST.KEYBOARD_TYPE.NUMERIC}
+                keyboardType={CONST.KEYBOARD_TYPE.NUMBER_PAD}
                 value={props.values.ssnLast4}
                 onChangeText={value => props.onFieldChange({ssnLast4: value})}
                 errorText={props.errors.ssnLast4 ? props.translate('bankAccount.error.ssnLast4') : ''}

diff --git a/src/pages/iou/steps/IOUAmountPage.js b/src/pages/iou/steps/IOUAmountPage.js
@@ -211,7 +211,7 @@ class IOUAmountPage extends React.Component {
                         ref={el => this.textInput = el}
                         value={this.state.amount}
                         placeholder="0"
-                        keyboardType={CONST.KEYBOARD_TYPE.NUMERIC}
+                        keyboardType={CONST.KEYBOARD_TYPE.NUMBER_PAD}
                     />
                 </View>
                 <View style={[styles.w100, styles.justifyContentEnd]}>

diff --git a/src/pages/settings/Payments/AddDebitCardPage.js b/src/pages/settings/Payments/AddDebitCardPage.js
@@ -221,7 +221,7 @@ class DebitCardPage extends Component {
                                         value={this.state.expirationDate}
                                         maxLength={7}
                                         errorText={this.getErrorText('expirationDate')}
-                                        keyboardType={CONST.KEYBOARD_TYPE.PHONE_PAD}
+                                        keyboardType={CONST.KEYBOARD_TYPE.NUMBER_PAD}
                                     />
                                 </View>
                                 <View style={[styles.flex1]}>
@@ -259,7 +259,7 @@ class DebitCardPage extends Component {
                                 <View style={[styles.flex2, styles.mr2]}>
                                     <TextInput
                                         label={this.props.translate('common.zip')}
-                                        keyboardType={CONST.KEYBOARD_TYPE.PHONE_PAD}
+                                        keyboardType={CONST.KEYBOARD_TYPE.NUMBER_PAD}
                                         onChangeText={value => this.clearErrorAndSetValue('addressZipCode', value)}
                                         value={this.state.addressZipCode}
                                         errorText={this.getErrorText('addressZipCode')}

diff --git a/src/pages/signin/PasswordForm.js b/src/pages/signin/PasswordForm.js
@@ -143,7 +143,7 @@ class PasswordForm extends React.Component {
                             placeholderTextColor={themeColors.placeholderText}
                             onChangeText={text => this.setState({twoFactorAuthCode: text})}
                             onSubmitEditing={this.validateAndSubmitForm}
-                            keyboardType={CONST.KEYBOARD_TYPE.NUMERIC}
+                            keyboardType={CONST.KEYBOARD_TYPE.NUMBER_PAD}
                             blurOnSubmit={false}
                         />
                     </View>