Muting try-catch for Chrome<45 + Background script import order

RamdanAzis · Feb 6, 2016 · 6c66bcf · 6c66bcf
1 parent a7d9f3a
commit 6c66bcf
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 6 deletions.
diff --git a/src/library/modules/Service.js b/src/library/modules/Service.js
@@ -128,7 +128,11 @@ See Manifest File [manifest.json] under "background" > "scripts"
 		------------------------------------------*/
 		"isMuted" :function(request, sender, response){
 			chrome.tabs.get(request.tabId, function(tabInfo){
-				response(tabInfo.mutedInfo.muted);
+				try {
+					response(tabInfo.mutedInfo.muted);
+				}catch(e){
+					response(false);
+				}
 			});
 			return true;
 		},
@@ -138,10 +142,14 @@ See Manifest File [manifest.json] under "background" > "scripts"
 		------------------------------------------*/
 		"toggleSounds" :function(request, sender, response){
 			chrome.tabs.get(request.tabId, function(tabInfo){
-				chrome.tabs.update(request.tabId, {
-					muted: tabInfo.mutedInfo.muted?false:true,
-				});
-				response(!tabInfo.mutedInfo.muted);
+				try {
+					chrome.tabs.update(request.tabId, {
+						muted: tabInfo.mutedInfo.muted?false:true,
+					});
+					response(!tabInfo.mutedInfo.muted);
+				}catch(e){
+					response(false);
+				}
 				return true;
 			});
 			return true;

diff --git a/src/manifest.json b/src/manifest.json
@@ -31,8 +31,8 @@
 	"background": {
 		"scripts": [
 			"assets/js/jquery-2.1.3.min.js",
-			"library/managers/ConfigManager.js",
 			"library/objects/Messengers.js",
+			"library/managers/ConfigManager.js",
 			"library/modules/Service.js"
 		]
 	},