Latest upstream updates #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FreeRDP uses clipboard->data to cache the result of the Windows->X11 clipboard format conversion, and xf_cliprdr_process_selection_request() immediately provides this result to local applications if they request the same clipboard format again. This saves us a possibly costly conversion in case where the user pastes data repeatedly. However, this caching mechanism did not support raw clipboard transfers where the unmodified data is passed between two FreeRDP clients. We use the same XClipboard protocol for this, so the clipboard->data is in play. We clear the cached value when we receive new data from the server, so initially raw transfers are fine. But if some local application (e.g., a clipboard manager) asks for some data format before the data is pasted into the second FreeRDP session then clipboard->data will contain the *converted* data. And this converted cached data will be provided to the second FreeRDP session as a part of the raw data transfer. Instead we should have provided the original data. In order to achieve this we are now caching the original data in the same way as the converted one, and the original data is now correctly provided when the second FreeRDP session asks for a raw data transfer.
Undefined behavior on "wfPeerContext *context", as it is accessed before being initialized or assigned. Fixed.
Fix cached clipboard responses during raw transfers
libwinpr-utils: fix 3 logic errors
core: Get rid of useless settings copy
Fixed undefined behavior in wf_peer_main_loop function
Use INIT_ONCE for SSPI initialisation. #3471
Ssse3 optimize and sanitize address
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.