Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to report incorrect entity value #11388

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix to report incorrect entity value #11388

wants to merge 1 commit into from

Conversation

rgstephens
Copy link
Contributor

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@rgstephens rgstephens requested a review from a team as a code owner July 22, 2022 21:19
@rgstephens rgstephens requested review from sanchariGr, ancalita and a team and removed request for a team July 22, 2022 21:19
ancalita
ancalita reviewed Jul 25, 2022
View reviewed changes
Copy link
Member

@ancalita ancalita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff 💯
Please add a unit test in tests/core/test_test.py reproducing the reported example in the issue to indicate the entity value is now reported in failed tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ancalita ancalita ancalita left review comments

@sanchariGr sanchariGr Awaiting requested review from sanchariGr sanchariGr was automatically assigned from RasaHQ/atom-squad

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rgstephens @ancalita