Add basic flow support #12134
Draft
Add basic flow support #12134
+756
−227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmbo
reviewed
Mar 15, 2023
| @@ -1020,6 +1028,18 @@ def __init__(self) -> None: | |||
| super().__init__("utter_ask_rephrase", silent_fail=True) | |||
|
|
|||
|
|
|||
| class ActionExtractSteps(Action): | |||
There was a problem hiding this comment.
Dont think it is :)
This whole PR is just crap code not meant to be reviewed yet :) Just messing around
There was a problem hiding this comment.
haha yeah for sure and i know, just trying to understand what you did :)
tmbo
reviewed
Mar 15, 2023
| logger = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| class FlowAction(FormAction): |
There was a problem hiding this comment.
before we go and implement more in this direction we should check if an action actually is the right place.
my first guess would have been that this should be a policy (like the rule policy) tbh - but I am not so sure about this. let me open a thread in the engine channel to check what others think
There was a problem hiding this comment.
(might also something that we need to toy with)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flows as a loop
Project repo: https://github.com/RasaHQ/rasa-project-with-flows