Armadillo 14.6.2 #470
Merged
Armadillo 14.6.2 #470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Armadillo C++ linear algebra library from version 14.6.1 to 14.6.2. The changes focus on refactoring sum operations by extracting common logic into a shared generic implementation.
- Refactored sum operation implementations to use a new
apply_genericfunction to reduce code duplication - Fixed OpenMP usage conditions by adding proper configuration checks
- Updated version number to 14.6.2
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| inst/include/armadillo_bits/op_sum_meat.hpp | Major refactoring to extract common sum logic into apply_generic function and simplify specialized implementations |
| inst/include/armadillo_bits/op_sum_bones.hpp | Added declaration for new apply_generic function |
| inst/include/armadillo_bits/op_omit_meat.hpp | Fixed OpenMP condition checks by adding arma_config::openmp guards |
| inst/include/armadillo_bits/arma_version.hpp | Updated patch version from 1 to 2 |
| ChangeLog | Added entry documenting the update to Armadillo 14.6.2 |
| } | ||
|
|
||
| op_sum::apply_generic(out, in); |
There was a problem hiding this comment.
[nitpick] The early return statement at line 70 creates an asymmetric control flow. Consider restructuring this as an if-else block to make the logic clearer and maintain consistent structure with the refactored generic approach.
Copilot uses AI. Check for mistakes.
|
Clean reverse-depends check, see RcppCore/rcpp-logs@7b2abea |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.