Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add laser compatibility with ae2 certus quartz cluster #226

Merged

Conversation

VasariRulez
Copy link
Contributor

Add PlayerEntity to getLootDrops and getDroppedStacks when laser finishBlockBreaking to add compatibility with ae2 certus quartz cluster

…shBlockBreaking to add compatibility with ae2 certus quartz cluster
@Rearth
Copy link
Owner

Rearth commented Dec 28, 2024

Hi, is this really something that should be changed on Oritechs side? From what I'm understanding here, the ae2 certus quartz cluster only drop when a player is in the loot context builder? That sounds like a bug that should be fixed on their side to me, no?
But I'm also fine with merging this PR. If having players as optional in the loot builders is something used not just for this one thing, then we should definitly merge this.

@VasariRulez
Copy link
Contributor Author

VasariRulez commented Dec 28, 2024

Hi,

From what I've seen in the AE2 code, they specifically check for an Entity in the LootParams Builder. It looks intentional and not a bug on their end.

image

I can't say for sure how many other things would benefit from this PR since I only looked at this interaction with AE2.

In the end, it's up to you to decide whether to merge this PR or not.
Have a nice day!

@Rearth
Copy link
Owner

Rearth commented Dec 28, 2024

Alright, thanks for digging into this issue on the AE2 side. I appreciate it.

@Rearth Rearth merged commit 277dfe2 into Rearth:1.21 Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants