Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed #230 (solar panel producing energy despite having blocks above) #231

Closed
wants to merge 1 commit into from

Conversation

Plompi
Copy link
Contributor

@Plompi Plompi commented Dec 29, 2024

this implementation might not be the best, but it does what i'm expecting, when a block is above the solar panel

@Plompi
Copy link
Contributor Author

Plompi commented Dec 29, 2024

currently this check only applies to the solar panel block itself (visually the solar panel has 6 panels, 5 of them dont react to blocks above them, even with this new implementation, so further development might be needed if this is also wanted)

@Rearth
Copy link
Owner

Rearth commented Jan 1, 2025

Hi, thanks for the PR. I'm not sure how I want to proceed here, as this also leads to new issues. I personally don't really care if the solar panel really does a correct sun check. If players want to cheese it, I'm fine with that.

The fact that solar panels rotate to face the sun makes this a lot harder, as sun may reach them early in the morning from the sides, so it should produce energy sometimes even if fully blocked. So the sky doesn't really have to be reachable for the solar panels to provide energy. The current implementation is a nice compromise where you need some sort of light, but other than that I'm fine with the solar panel working with blocks nearby. This makes it easier for the players to understand. Otherwise players would complain that the panel doesn't work because there is a block somewhere above it, even though most panel blocks are unobstructed from most directions.

@Rearth Rearth closed this Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants