Portable storage piston/dispenser behaviors #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Huh, didnt even know datapacks can do that. I'll keep this in mind for a few things in the future. Huge thanks again for the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, portable tank and portable energy storage can be broken by pistons and placed by dispensers, just like shulker boxes. This enables redstone filling mechanisms that can keep replacing full storage blocks with empty storage blocks (or vice versa). Super useful for carrying large amounts of lava around (or letting drones carry them around).
The biggest change here is adding block_loot datagen for the Portable Tank and Portable Energy Storage that stores Nbt data in the dropped items.
onBreak() wasn't being called when the blocks were destroyed by pistons, so getDroppedStacks() was implemented to make sure that the blocks were dropping their inventory items when they are broken. This should work when broken by a player, or by a piston, or by an explosion.
Between the new block loot and getDroppedStacks(), the onBreak() methods were redundant and were removed.