Added hitboxes to machine addons #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jshipley
commented
Aug 21, 2024
jshipley
commented
- Added static initialization to machine addons for hitboxes with all facing/face rotations
- Addon machine blocks that don't have a hitbox will default to full cube
- Added Geometry.rotateVoxelShape() utility function
- Converted machine addon parameter list to an AddonSettings record (with with* functions)
- Updated item blockstates / models to all have consistent rotation, lighting, item frame view, etc.
* Addons should now be consistently rotated for face/facings (and match items) * Addon items should be lit from the front so that they look better in gui / manual * Shorter addon blocks turned to lay flat in item frames
|
Damn that's a huge list of changes, but surely a welcome one. I really appreciate all the effort that went into this. Updates collision shapes are something that the addons definitly needed. Also didn't even know we coul;d adjust the lighting in the previews |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.