Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reg 3213 improve robustness of exception handling standalone.py #1

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

monicaihli
Copy link
Collaborator

Extensive refactor addresses several issues.:
(1) Script in existing form permitted failed key generation to proceed with installation. Any failure to substitute default keys with dynamically generated keys should not be allowed to progress, in order to prevent security risk of duplicate keys.
(2) Clarified the nature of errors being reported in messages to user during installation. Ensured all possible points of failure are now explicitly addressed.
(3) Refactored out redundant code to improve maintainability.
(4) Added logic to use either v1 or v2 docker compose, depending on what is installed on local system.

@geoffmazeroff geoffmazeroff requested review from elruss and BelardoA May 30, 2023 15:53
@BelardoA
Copy link
Collaborator

I tried running this on a fresh ubuntu docker container and fresh ubuntu vm and here are my takeaways:

  • It assumes I have pip3 installed, it should follow the logic to see if pip3 is installed and if not it installs it (if not the documentation should have prerequisites before running standalone.py
  • It errors when trying to install docker: Unknown error installing dependency: No module named 'docker'. and exits
  • The script doesn't work on python 3.8, so possibly add a python version check before proceeding as well like the pip check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants