RSDK-840 removed redundant check connections (viamrobotics#1895)

RoxyFarhad · Feb 17, 2023 · 0a72d28 · 0a72d28
1 parent 8ef24d3
commit 0a72d28
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/robot/client/client.go b/robot/client/client.go
@@ -608,9 +608,6 @@ func (rc *RobotClient) resources(ctx context.Context) ([]resource.Name, []resour
 func (rc *RobotClient) Refresh(ctx context.Context) (err error) {
 	rc.mu.Lock()
 	defer rc.mu.Unlock()
-	if err := rc.checkConnected(); err != nil {
-		return err
-	}
 	return rc.updateResources(ctx, updateReasonRefresh)
 }
 

diff --git a/robot/client/client_test.go b/robot/client/client_test.go
@@ -1602,6 +1602,12 @@ func TestNewRobotClientRefresh(t *testing.T) {
 	test.That(t, client, test.ShouldNotBeNil)
 	test.That(t, callCount, test.ShouldEqual, 1)
 
+	gServer.Stop()
+	test.That(t, <-client.Changed(), test.ShouldBeTrue)
+	test.That(t, client.Connected(), test.ShouldBeFalse)
+	err = client.Refresh(context.Background())
+	test.That(t, err.Error(), test.ShouldContainSubstring, "not connected to remote robot")
+
 	err = client.Close(context.Background())
 	test.That(t, err, test.ShouldBeNil)
 }