Allow instructions to explicitly specify StorageClasses #236
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds an optional
StorageClass
toSpirvType::Pointer
to allow instructions to explicitly specify it on their results.Required for
Motivation
Currently storage classes are only inferred from interface variables. However, there is a number of instructions that have results with implicit storage classes (i.e. that "create provenance" on the fly).
These include
OpConvertUToPtr
creates aPhysicalStorageBuffer
pointerOpBitcast
can be used to create aPhysicalStorageBuffer
pointer fromu64
oruvec2
(ifInt64
is not supported)OpImageTexelPointer
creates anImage
pointerUniform
/StorageBuffer
pointersIt should be possible to generate these both in the compiler (e.g.
u64 as *const T
) and throughasm!
for unknown instructions.This is a requirement for the
PhysicalStorageBuffer
addressing model as well as upcoming more modern bindless extensions.For example we can now write (or generate in
inttoptr
)Implementation steps
Generic
requirement inasm!
.Generic
is still used to indicate automatic inferrence.qptr
storage class inference.InferVar
s for non-Generic
storage classes or infer instances based on concrete typesOpImageTexelPointer