Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui5-timeline-item): introduce status property #10277

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

hinzzx
Copy link
Contributor

@hinzzx hinzzx commented Nov 29, 2024

Introducing status property into the <ui5-timeline-item> web component.

The status property allows you to set the semantic state of the icon using the following values: Information, Positive, Critical, Negative or None.
Each status automatically changes the icon's color to visually represent the corresponding state, improving clarity and consistency.
The status is also accessible. Screen readers will read the status, ensuring that users with assistive technologies can understand the semantic meaning.

Sample usecases with and without status property

With

image

Without

image

Copy link
Contributor

@unazko unazko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • From the commit description - the semantic meaning gets set over the ui5-timeline-item and not only over the icon.
  • You could add a test, in order to check whether the accessible-description property results into aria-description over the inner element.

Tested with NVDA and JAWS. The announcements are as expected.

packages/fiori/src/themes/TimelineItem.css Outdated Show resolved Hide resolved
packages/fiori/src/TimelineItem.ts Outdated Show resolved Hide resolved
packages/fiori/src/TimelineItem.ts Outdated Show resolved Hide resolved
packages/fiori/src/types/TimelineItemStatus.ts Outdated Show resolved Hide resolved
packages/fiori/src/types/TimelineItemStatus.ts Outdated Show resolved Hide resolved
packages/fiori/src/types/TimelineItemStatus.ts Outdated Show resolved Hide resolved
packages/fiori/src/types/TimelineItemStatus.ts Outdated Show resolved Hide resolved
packages/fiori/src/types/TimelineItemStatus.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants