Backuplink Telemetry Update #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -458,9 +458,9 @@ class Telemetry : public PluginBase { | |||
| */ | |||
| struct VehicleStatus { | |||
| bool manual_control_signal_loss{false}; /**< @brief True if manual control signal is loss */ | |||
| bool data_link_loss{false}; /**< @brief True if the data link is loss */ | |||
| uint32_t mavlink_count{false}; /**< @brief Number of Mavlink connections providing setpoints (implying joystick connected). Should be < 2.*/ | |||
There was a problem hiding this comment.
We should initialize the mavlink_count with the correct initialization value, i.e. 0, rather than false.
DavidPaddy97
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is interlinked with these:
For more detail, refer to those.
In short, we are now looking at the number of Mavlink connections providing setpoints (joystick connected) to determine if Backup GCS is connected.
We are also now monitoring the desired source as this is more informative with the way we toggle between source types.