Skip to content

Commit

Permalink
fix editor (qiankanglai#174)
Browse files Browse the repository at this point in the history 
improve inspector (thanks to @tuanpm62 )
  • Loading branch information
@tuanpm62
tuanpm62 authored Jun 22, 2024
1 parent 16c8773 commit 03ab6b6
Show file tree
Hide file tree
Showing 2 changed files with 207 additions and 18 deletions.
181 changes: 177 additions & 4 deletions Editor/LoopScrollRectInspector.cs
View file
Original file line number Diff line number Diff line change
@@ -1,16 +1,185 @@
using UnityEngine;
using UnityEngine.UI;
using UnityEditor;
using UnityEditor.AnimatedValues;

[CustomEditor(typeof(LoopScrollRect), true)]
public class LoopScrollRectInspector : Editor
{
SerializedProperty m_Content;
SerializedProperty m_Horizontal;
SerializedProperty m_Vertical;
SerializedProperty m_MovementType;
SerializedProperty m_Elasticity;
SerializedProperty m_Inertia;
SerializedProperty m_DecelerationRate;
SerializedProperty m_ScrollSensitivity;
SerializedProperty m_Viewport;
SerializedProperty m_HorizontalScrollbar;
SerializedProperty m_VerticalScrollbar;
SerializedProperty m_HorizontalScrollbarVisibility;
SerializedProperty m_VerticalScrollbarVisibility;
SerializedProperty m_HorizontalScrollbarSpacing;
SerializedProperty m_VerticalScrollbarSpacing;
SerializedProperty m_OnValueChanged;
AnimBool m_ShowElasticity;
AnimBool m_ShowDecelerationRate;
bool m_ViewportIsNotChild, m_HScrollbarIsNotChild, m_VScrollbarIsNotChild;
static string s_HError = "For this visibility mode, the Viewport property and the Horizontal Scrollbar property both needs to be set to a Rect Transform that is a child to the Scroll Rect.";
static string s_VError = "For this visibility mode, the Viewport property and the Vertical Scrollbar property both needs to be set to a Rect Transform that is a child to the Scroll Rect.";

//==========LoopScrollRect==========
SerializedProperty totalCount;
SerializedProperty reverseDirection;
int index = 0;
float speed = 1000, time = 1;
public override void OnInspectorGUI ()

protected virtual void OnEnable()
{
m_Content = serializedObject.FindProperty("m_Content");
m_Horizontal = serializedObject.FindProperty("m_Horizontal");
m_Vertical = serializedObject.FindProperty("m_Vertical");
m_MovementType = serializedObject.FindProperty("m_MovementType");
m_Elasticity = serializedObject.FindProperty("m_Elasticity");
m_Inertia = serializedObject.FindProperty("m_Inertia");
m_DecelerationRate = serializedObject.FindProperty("m_DecelerationRate");
m_ScrollSensitivity = serializedObject.FindProperty("m_ScrollSensitivity");
m_Viewport = serializedObject.FindProperty("m_Viewport");
m_HorizontalScrollbar = serializedObject.FindProperty("m_HorizontalScrollbar");
m_VerticalScrollbar = serializedObject.FindProperty("m_VerticalScrollbar");
m_HorizontalScrollbarVisibility = serializedObject.FindProperty("m_HorizontalScrollbarVisibility");
m_VerticalScrollbarVisibility = serializedObject.FindProperty("m_VerticalScrollbarVisibility");
m_HorizontalScrollbarSpacing = serializedObject.FindProperty("m_HorizontalScrollbarSpacing");
m_VerticalScrollbarSpacing = serializedObject.FindProperty("m_VerticalScrollbarSpacing");
m_OnValueChanged = serializedObject.FindProperty("m_OnValueChanged");

m_ShowElasticity = new AnimBool(Repaint);
m_ShowDecelerationRate = new AnimBool(Repaint);
SetAnimBools(true);

//==========LoopScrollRect==========
totalCount = serializedObject.FindProperty("totalCount");
reverseDirection = serializedObject.FindProperty("reverseDirection");
}

protected virtual void OnDisable()
{
m_ShowElasticity.valueChanged.RemoveListener(Repaint);
m_ShowDecelerationRate.valueChanged.RemoveListener(Repaint);
}

void SetAnimBools(bool instant)
{
SetAnimBool(m_ShowElasticity, !m_MovementType.hasMultipleDifferentValues && m_MovementType.enumValueIndex == (int)ScrollRect.MovementType.Elastic, instant);
SetAnimBool(m_ShowDecelerationRate, !m_Inertia.hasMultipleDifferentValues && m_Inertia.boolValue == true, instant);
}

void SetAnimBool(AnimBool a, bool value, bool instant)
{
base.OnInspectorGUI();
if (instant)
a.value = value;
else
a.target = value;
}

void CalculateCachedValues()
{
m_ViewportIsNotChild = false;
m_HScrollbarIsNotChild = false;
m_VScrollbarIsNotChild = false;
if (targets.Length == 1)
{
Transform transform = ((LoopScrollRect)target).transform;
if (m_Viewport.objectReferenceValue == null || ((RectTransform)m_Viewport.objectReferenceValue).transform.parent != transform)
m_ViewportIsNotChild = true;
if (m_HorizontalScrollbar.objectReferenceValue == null || ((Scrollbar)m_HorizontalScrollbar.objectReferenceValue).transform.parent != transform)
m_HScrollbarIsNotChild = true;
if (m_VerticalScrollbar.objectReferenceValue == null || ((Scrollbar)m_VerticalScrollbar.objectReferenceValue).transform.parent != transform)
m_VScrollbarIsNotChild = true;
}
}

public override void OnInspectorGUI()
{
SetAnimBools(false);

serializedObject.Update();
// Once we have a reliable way to know if the object changed, only re-cache in that case.
CalculateCachedValues();

EditorGUILayout.PropertyField(m_Content);

EditorGUILayout.PropertyField(m_Horizontal);
EditorGUILayout.PropertyField(m_Vertical);

EditorGUILayout.PropertyField(m_MovementType);
if (EditorGUILayout.BeginFadeGroup(m_ShowElasticity.faded))
{
EditorGUI.indentLevel++;
EditorGUILayout.PropertyField(m_Elasticity);
EditorGUI.indentLevel--;
}
EditorGUILayout.EndFadeGroup();

EditorGUILayout.PropertyField(m_Inertia);
if (EditorGUILayout.BeginFadeGroup(m_ShowDecelerationRate.faded))
{
EditorGUI.indentLevel++;
EditorGUILayout.PropertyField(m_DecelerationRate);
EditorGUI.indentLevel--;
}
EditorGUILayout.EndFadeGroup();

EditorGUILayout.PropertyField(m_ScrollSensitivity);

EditorGUILayout.Space();

EditorGUILayout.PropertyField(m_Viewport);

EditorGUILayout.PropertyField(m_HorizontalScrollbar);
if (m_HorizontalScrollbar.objectReferenceValue && !m_HorizontalScrollbar.hasMultipleDifferentValues)
{
EditorGUI.indentLevel++;
EditorGUILayout.PropertyField(m_HorizontalScrollbarVisibility, EditorGUIUtility.TrTextContent("Visibility"));

if ((ScrollRect.ScrollbarVisibility)m_HorizontalScrollbarVisibility.enumValueIndex == ScrollRect.ScrollbarVisibility.AutoHideAndExpandViewport
&& !m_HorizontalScrollbarVisibility.hasMultipleDifferentValues)
{
if (m_ViewportIsNotChild || m_HScrollbarIsNotChild)
EditorGUILayout.HelpBox(s_HError, MessageType.Error);
EditorGUILayout.PropertyField(m_HorizontalScrollbarSpacing, EditorGUIUtility.TrTextContent("Spacing"));
}

EditorGUI.indentLevel--;
}

EditorGUILayout.PropertyField(m_VerticalScrollbar);
if (m_VerticalScrollbar.objectReferenceValue && !m_VerticalScrollbar.hasMultipleDifferentValues)
{
EditorGUI.indentLevel++;
EditorGUILayout.PropertyField(m_VerticalScrollbarVisibility, EditorGUIUtility.TrTextContent("Visibility"));

if ((ScrollRect.ScrollbarVisibility)m_VerticalScrollbarVisibility.enumValueIndex == ScrollRect.ScrollbarVisibility.AutoHideAndExpandViewport
&& !m_VerticalScrollbarVisibility.hasMultipleDifferentValues)
{
if (m_ViewportIsNotChild || m_VScrollbarIsNotChild)
EditorGUILayout.HelpBox(s_VError, MessageType.Error);
EditorGUILayout.PropertyField(m_VerticalScrollbarSpacing, EditorGUIUtility.TrTextContent("Spacing"));
}

EditorGUI.indentLevel--;
}

EditorGUILayout.Space();

EditorGUILayout.PropertyField(m_OnValueChanged);

serializedObject.ApplyModifiedProperties();

//==========LoopScrollRect==========
EditorGUILayout.Space();
EditorGUILayout.PropertyField(totalCount);
EditorGUILayout.PropertyField(reverseDirection);

LoopScrollRect scroll = (LoopScrollRect)target;
GUI.enabled = Application.isPlaying;
Expand Down Expand Up @@ -39,7 +208,9 @@ public override void OnInspectorGUI ()
index = EditorGUILayout.IntField("Index", index, GUILayout.Width(w));
EditorGUILayout.BeginHorizontal();
EditorGUIUtility.labelWidth = 60;
speed = EditorGUILayout.FloatField(" Speed", speed, GUILayout.Width(w+15));
EditorGUI.indentLevel++;
speed = EditorGUILayout.FloatField("Speed", speed, GUILayout.Width(w+15));
EditorGUI.indentLevel--;
if(GUILayout.Button("Scroll With Speed", GUILayout.Width(130)))
{
scroll.ScrollToCell(index, speed);
Expand All @@ -48,7 +219,9 @@ public override void OnInspectorGUI ()

EditorGUILayout.BeginHorizontal();
EditorGUIUtility.labelWidth = 60;
time = EditorGUILayout.FloatField(" Time", time, GUILayout.Width(w+15));
EditorGUI.indentLevel++;
time = EditorGUILayout.FloatField("Time", time, GUILayout.Width(w+15));
EditorGUI.indentLevel--;
if(GUILayout.Button("Scroll Within Time", GUILayout.Width(130)))
{
scroll.ScrollToCellWithinTime(index, time);
Expand Down
44 changes: 30 additions & 14 deletions Editor/SGDefaultControls.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -83,19 +83,29 @@ public static GameObject CreateLoopHorizontalScrollRect(DefaultControls.Resource
{
GameObject root = CreateUIElementRoot("Loop Horizontal Scroll Rect", new Vector2(200, 200));

GameObject content = CreateUIObject("Content", root);
GameObject viewport = CreateUIObject("Viewport", root);

RectTransform viewportRT = viewport.GetComponent<RectTransform>();
viewportRT.anchorMin = new Vector2(0, 0);
viewportRT.anchorMax = new Vector2(1, 1);
viewportRT.sizeDelta = new Vector2(0, 0);
viewportRT.pivot = new Vector2(0.5f, 0.5f);

viewport.AddComponent<RectMask2D>();

GameObject content = CreateUIObject("Content", viewport);

RectTransform contentRT = content.GetComponent<RectTransform>();
contentRT.anchorMin = new Vector2(0, 0.5f);
contentRT.anchorMax = new Vector2(0, 0.5f);
contentRT.sizeDelta = new Vector2(0, 200);
contentRT.anchorMin = new Vector2(0, 0);
contentRT.anchorMax = new Vector2(0, 1);
contentRT.sizeDelta = new Vector2(0, 0);
contentRT.pivot = new Vector2(0, 0.5f);

// Setup UI components.

LoopHorizontalScrollRect scrollRect = root.AddComponent<LoopHorizontalScrollRect>();
scrollRect.content = contentRT;
scrollRect.viewport = null;
scrollRect.viewport = viewportRT;
scrollRect.horizontalScrollbar = null;
scrollRect.verticalScrollbar = null;
scrollRect.horizontal = true;
Expand All @@ -105,8 +115,6 @@ public static GameObject CreateLoopHorizontalScrollRect(DefaultControls.Resource
scrollRect.horizontalScrollbarSpacing = 0;
scrollRect.verticalScrollbarSpacing = 0;

root.AddComponent<RectMask2D>();

HorizontalLayoutGroup layoutGroup = content.AddComponent<HorizontalLayoutGroup>();
layoutGroup.childAlignment = TextAnchor.MiddleLeft;
layoutGroup.childForceExpandWidth = false;
Expand All @@ -123,19 +131,29 @@ public static GameObject CreateLoopVerticalScrollRect(DefaultControls.Resources
{
GameObject root = CreateUIElementRoot("Loop Vertical Scroll Rect", new Vector2(200, 200));

GameObject content = CreateUIObject("Content", root);
GameObject viewport = CreateUIObject("Viewport", root);

RectTransform viewportRT = viewport.GetComponent<RectTransform>();
viewportRT.anchorMin = new Vector2(0, 0);
viewportRT.anchorMax = new Vector2(1, 1);
viewportRT.sizeDelta = new Vector2(0, 0);
viewportRT.pivot = new Vector2(0.5f, 0.5f);

viewport.AddComponent<RectMask2D>();

GameObject content = CreateUIObject("Content", viewport);

RectTransform contentRT = content.GetComponent<RectTransform>();
contentRT.anchorMin = new Vector2(0.5f, 1);
contentRT.anchorMax = new Vector2(0.5f, 1);
contentRT.sizeDelta = new Vector2(200, 0);
contentRT.anchorMin = new Vector2(0, 1);
contentRT.anchorMax = new Vector2(1, 1);
contentRT.sizeDelta = new Vector2(0, 0);
contentRT.pivot = new Vector2(0.5f, 1);

// Setup UI components.

LoopVerticalScrollRect scrollRect = root.AddComponent<LoopVerticalScrollRect>();
scrollRect.content = contentRT;
scrollRect.viewport = null;
scrollRect.viewport = viewportRT;
scrollRect.horizontalScrollbar = null;
scrollRect.verticalScrollbar = null;
scrollRect.horizontal = false;
Expand All @@ -145,8 +163,6 @@ public static GameObject CreateLoopVerticalScrollRect(DefaultControls.Resources
scrollRect.horizontalScrollbarSpacing = 0;
scrollRect.verticalScrollbarSpacing = 0;

root.AddComponent<RectMask2D>();

VerticalLayoutGroup layoutGroup = content.AddComponent<VerticalLayoutGroup>();
layoutGroup.childAlignment = TextAnchor.UpperCenter;
layoutGroup.childForceExpandWidth = true;
Expand Down

0 comments on commit 03ab6b6

Please sign in to comment.