Skip to content

Commit

Permalink
Safe codegen formatting changes (stripe#573)
Browse files Browse the repository at this point in the history
* Safe formatting changes from dmitry's branch

branch: dmitrykorolev/codegen
pr: stripe#565

* Split some imports for better uniq'ing

* Sort with basic case-sensitive algo

* Reorder nested resource imports

* Reorder a comment in a way that is more convenient
  • Loading branch information
rattrayalex-stripe authored May 21, 2019
1 parent dafeb2d commit f51dbeb
Show file tree
Hide file tree
Showing 47 changed files with 117 additions and 108 deletions.
27 changes: 14 additions & 13 deletions stripe/api_resources/account.py
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
from __future__ import absolute_import, division, print_function

import stripe
from stripe import oauth, six, util
from stripe import oauth, six
from stripe import util
from stripe.api_resources.abstract import CreateableAPIResource
from stripe.api_resources.abstract import DeletableAPIResource
from stripe.api_resources.abstract import UpdateableAPIResource
from stripe.api_resources.abstract import ListableAPIResource
from stripe.api_resources.abstract import nested_resource_class_methods
from stripe.api_resources.abstract import UpdateableAPIResource
from stripe.api_resources.abstract import custom_method
from stripe.api_resources.abstract import nested_resource_class_methods
from stripe.six.moves.urllib.parse import quote_plus


Expand All @@ -27,12 +28,21 @@
)
class Account(
CreateableAPIResource,
DeletableAPIResource,
ListableAPIResource,
UpdateableAPIResource,
DeletableAPIResource,
):
OBJECT_NAME = "account"

def reject(self, idempotency_key=None, **params):
url = self.instance_url() + "/reject"
headers = util.populate_headers(idempotency_key)
self.refresh_from(self.request("post", url, params, headers))
return self

# We are not adding a helper for capabilities here as the Account object already has a
# capabilities property which is a hash and not the sub-list of capabilities.

@classmethod
def retrieve(cls, id=None, api_key=None, **params):
instance = cls(id, api_key, **params)
Expand All @@ -59,15 +69,6 @@ def instance_url(self):
def persons(self, **params):
return self.request("get", self.instance_url() + "/persons", params)

# We are not adding a helper for capabilities here as the Account object already has a
# capabilities property which is a hash and not the sub-list of capabilities.

def reject(self, idempotency_key=None, **params):
url = self.instance_url() + "/reject"
headers = util.populate_headers(idempotency_key)
self.refresh_from(self.request("post", url, params, headers))
return self

def deauthorize(self, **params):
params["stripe_user_id"] = self.id
return oauth.OAuth.deauthorize(**params)
Expand Down
5 changes: 2 additions & 3 deletions stripe/api_resources/alipay_account.py
Original file line number Diff line number Diff line change
@@ -1,14 +1,13 @@
from __future__ import absolute_import, division, print_function

from stripe import util
from stripe.api_resources.customer import Customer
from stripe.api_resources.abstract import DeletableAPIResource
from stripe.api_resources.abstract import UpdateableAPIResource

from stripe.api_resources.customer import Customer
from stripe.six.moves.urllib.parse import quote_plus


class AlipayAccount(UpdateableAPIResource, DeletableAPIResource):
class AlipayAccount(DeletableAPIResource, UpdateableAPIResource):
OBJECT_NAME = "alipay_account"

@classmethod
Expand Down
2 changes: 1 addition & 1 deletion stripe/api_resources/apple_pay_domain.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@


class ApplePayDomain(
CreateableAPIResource, ListableAPIResource, DeletableAPIResource
CreateableAPIResource, DeletableAPIResource, ListableAPIResource
):
OBJECT_NAME = "apple_pay_domain"

Expand Down
1 change: 0 additions & 1 deletion stripe/api_resources/application_fee_refund.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
from stripe import util
from stripe.api_resources import ApplicationFee
from stripe.api_resources.abstract import UpdateableAPIResource

from stripe.six.moves.urllib.parse import quote_plus


Expand Down
11 changes: 6 additions & 5 deletions stripe/api_resources/bank_account.py
Original file line number Diff line number Diff line change
@@ -1,15 +1,16 @@
from __future__ import absolute_import, division, print_function

from stripe import error, util
from stripe.api_resources.account import Account
from stripe.api_resources.customer import Customer
from stripe.api_resources.abstract import UpdateableAPIResource
from stripe import error
from stripe import util
from stripe.api_resources.abstract import DeletableAPIResource
from stripe.api_resources.abstract import UpdateableAPIResource
from stripe.api_resources.abstract import VerifyMixin
from stripe.api_resources.account import Account
from stripe.api_resources.customer import Customer
from stripe.six.moves.urllib.parse import quote_plus


class BankAccount(UpdateableAPIResource, DeletableAPIResource, VerifyMixin):
class BankAccount(DeletableAPIResource, UpdateableAPIResource, VerifyMixin):
OBJECT_NAME = "bank_account"

def instance_url(self):
Expand Down
2 changes: 1 addition & 1 deletion stripe/api_resources/bitcoin_receiver.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
from __future__ import absolute_import, division, print_function

from stripe import util
from stripe.api_resources.customer import Customer
from stripe.api_resources.abstract import ListableAPIResource
from stripe.api_resources.customer import Customer
from stripe.six.moves.urllib.parse import quote_plus


Expand Down
9 changes: 5 additions & 4 deletions stripe/api_resources/card.py
Original file line number Diff line number Diff line change
@@ -1,15 +1,16 @@
from __future__ import absolute_import, division, print_function

from stripe import error, util
from stripe import error
from stripe import util
from stripe.api_resources.abstract import DeletableAPIResource
from stripe.api_resources.abstract import UpdateableAPIResource
from stripe.api_resources.account import Account
from stripe.api_resources.customer import Customer
from stripe.api_resources.recipient import Recipient
from stripe.api_resources.abstract import UpdateableAPIResource
from stripe.api_resources.abstract import DeletableAPIResource
from stripe.six.moves.urllib.parse import quote_plus


class Card(UpdateableAPIResource, DeletableAPIResource):
class Card(DeletableAPIResource, UpdateableAPIResource):
OBJECT_NAME = "card"

def instance_url(self):
Expand Down
13 changes: 7 additions & 6 deletions stripe/api_resources/charge.py
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
from __future__ import absolute_import, division, print_function

from stripe import api_requestor, util
from stripe import api_requestor
from stripe import util
from stripe.api_resources.abstract import CreateableAPIResource
from stripe.api_resources.abstract import UpdateableAPIResource
from stripe.api_resources.abstract import ListableAPIResource
from stripe.api_resources.abstract import UpdateableAPIResource
from stripe.api_resources.abstract import custom_method


Expand All @@ -13,14 +14,14 @@ class Charge(
):
OBJECT_NAME = "charge"

def refund(self, idempotency_key=None, **params):
url = self.instance_url() + "/refund"
def capture(self, idempotency_key=None, **params):
url = self.instance_url() + "/capture"
headers = util.populate_headers(idempotency_key)
self.refresh_from(self.request("post", url, params, headers))
return self

def capture(self, idempotency_key=None, **params):
url = self.instance_url() + "/capture"
def refund(self, idempotency_key=None, **params):
url = self.instance_url() + "/refund"
headers = util.populate_headers(idempotency_key)
self.refresh_from(self.request("post", url, params, headers))
return self
Expand Down
4 changes: 2 additions & 2 deletions stripe/api_resources/country_spec.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from __future__ import absolute_import, division, print_function

from stripe.api_resources import abstract
from stripe.api_resources.abstract import ListableAPIResource


class CountrySpec(abstract.ListableAPIResource):
class CountrySpec(ListableAPIResource):
OBJECT_NAME = "country_spec"
4 changes: 2 additions & 2 deletions stripe/api_resources/coupon.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@

from stripe.api_resources.abstract import CreateableAPIResource
from stripe.api_resources.abstract import DeletableAPIResource
from stripe.api_resources.abstract import UpdateableAPIResource
from stripe.api_resources.abstract import ListableAPIResource
from stripe.api_resources.abstract import UpdateableAPIResource


class Coupon(
CreateableAPIResource,
UpdateableAPIResource,
DeletableAPIResource,
ListableAPIResource,
UpdateableAPIResource,
):
OBJECT_NAME = "coupon"
4 changes: 2 additions & 2 deletions stripe/api_resources/credit_note.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@

from stripe import util
from stripe.api_resources.abstract import CreateableAPIResource
from stripe.api_resources.abstract import UpdateableAPIResource
from stripe.api_resources.abstract import ListableAPIResource
from stripe.api_resources.abstract import UpdateableAPIResource
from stripe.api_resources.abstract import custom_method


@custom_method("void_credit_note", http_verb="post", http_path="void")
class CreditNote(
CreateableAPIResource, UpdateableAPIResource, ListableAPIResource
CreateableAPIResource, ListableAPIResource, UpdateableAPIResource
):
OBJECT_NAME = "credit_note"

Expand Down
6 changes: 3 additions & 3 deletions stripe/api_resources/customer.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
from stripe import api_requestor
from stripe.api_resources.abstract import CreateableAPIResource
from stripe.api_resources.abstract import DeletableAPIResource
from stripe.api_resources.abstract import UpdateableAPIResource
from stripe.api_resources.abstract import ListableAPIResource
from stripe.api_resources.abstract import UpdateableAPIResource
from stripe.api_resources.abstract import custom_method
from stripe.api_resources.abstract import nested_resource_class_methods

Expand All @@ -18,9 +18,9 @@
)
class Customer(
CreateableAPIResource,
UpdateableAPIResource,
ListableAPIResource,
DeletableAPIResource,
ListableAPIResource,
UpdateableAPIResource,
):
OBJECT_NAME = "customer"

Expand Down
3 changes: 2 additions & 1 deletion stripe/api_resources/ephemeral_key.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
from __future__ import absolute_import, division, print_function

from stripe import api_requestor, util
from stripe import api_requestor
from stripe import util
from stripe.api_resources.abstract import DeletableAPIResource


Expand Down
4 changes: 2 additions & 2 deletions stripe/api_resources/event.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from __future__ import absolute_import, division, print_function

from stripe.api_resources import abstract
from stripe.api_resources.abstract import ListableAPIResource


class Event(abstract.ListableAPIResource):
class Event(ListableAPIResource):
OBJECT_NAME = "event"
6 changes: 4 additions & 2 deletions stripe/api_resources/file.py
Original file line number Diff line number Diff line change
@@ -1,16 +1,18 @@
from __future__ import absolute_import, division, print_function

import stripe
from stripe import api_requestor, util
from stripe import api_requestor
from stripe import util
from stripe.api_resources.abstract import ListableAPIResource


class File(ListableAPIResource):
OBJECT_NAME = "file"

# This resource can have two different object names. In latter API
# versions, only `file` is used, but since stripe-python may be used with
# any API version, we need to support deserializing the older
# `file_upload` object into the same class.
OBJECT_NAME = "file"
OBJECT_NAME_ALT = "file_upload"

@classmethod
Expand Down
2 changes: 1 addition & 1 deletion stripe/api_resources/file_link.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
from __future__ import absolute_import, division, print_function

from stripe.api_resources.abstract import CreateableAPIResource
from stripe.api_resources.abstract import UpdateableAPIResource
from stripe.api_resources.abstract import ListableAPIResource
from stripe.api_resources.abstract import UpdateableAPIResource


class FileLink(
Expand Down
19 changes: 10 additions & 9 deletions stripe/api_resources/invoice.py
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
from __future__ import absolute_import, division, print_function

from stripe import api_requestor, util
from stripe import api_requestor
from stripe import util
from stripe.api_resources.abstract import CreateableAPIResource
from stripe.api_resources.abstract import DeletableAPIResource
from stripe.api_resources.abstract import UpdateableAPIResource
from stripe.api_resources.abstract import ListableAPIResource
from stripe.api_resources.abstract import UpdateableAPIResource
from stripe.api_resources.abstract import custom_method


Expand All @@ -15,9 +16,9 @@
@custom_method("void_invoice", http_verb="post", http_path="void")
class Invoice(
CreateableAPIResource,
UpdateableAPIResource,
DeletableAPIResource,
ListableAPIResource,
UpdateableAPIResource,
):
OBJECT_NAME = "invoice"

Expand Down Expand Up @@ -45,6 +46,12 @@ def send_invoice(self, idempotency_key=None, **params):
self.refresh_from(self.request("post", url, params, headers))
return self

def void_invoice(self, idempotency_key=None, **params):
url = self.instance_url() + "/void"
headers = util.populate_headers(idempotency_key)
self.refresh_from(self.request("post", url, params, headers))
return self

@classmethod
def upcoming(
cls, api_key=None, stripe_version=None, stripe_account=None, **params
Expand All @@ -57,9 +64,3 @@ def upcoming(
return util.convert_to_stripe_object(
response, api_key, stripe_version, stripe_account
)

def void_invoice(self, idempotency_key=None, **params):
url = self.instance_url() + "/void"
headers = util.populate_headers(idempotency_key)
self.refresh_from(self.request("post", url, params, headers))
return self
6 changes: 3 additions & 3 deletions stripe/api_resources/invoice_item.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@

from stripe.api_resources.abstract import CreateableAPIResource
from stripe.api_resources.abstract import DeletableAPIResource
from stripe.api_resources.abstract import UpdateableAPIResource
from stripe.api_resources.abstract import ListableAPIResource
from stripe.api_resources.abstract import UpdateableAPIResource


class InvoiceItem(
CreateableAPIResource,
UpdateableAPIResource,
ListableAPIResource,
DeletableAPIResource,
ListableAPIResource,
UpdateableAPIResource,
):
OBJECT_NAME = "invoiceitem"
2 changes: 2 additions & 0 deletions stripe/api_resources/issuer_fraud_record.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
from __future__ import absolute_import, division, print_function

from stripe.api_resources.abstract import ListableAPIResource


Expand Down
2 changes: 1 addition & 1 deletion stripe/api_resources/issuing/authorization.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
from __future__ import absolute_import, division, print_function

from stripe import util
from stripe.api_resources.abstract import UpdateableAPIResource
from stripe.api_resources.abstract import ListableAPIResource
from stripe.api_resources.abstract import UpdateableAPIResource
from stripe.api_resources.abstract import custom_method


Expand Down
2 changes: 1 addition & 1 deletion stripe/api_resources/issuing/card.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
from __future__ import absolute_import, division, print_function

from stripe.api_resources.abstract import CreateableAPIResource
from stripe.api_resources.abstract import UpdateableAPIResource
from stripe.api_resources.abstract import ListableAPIResource
from stripe.api_resources.abstract import UpdateableAPIResource
from stripe.api_resources.abstract import custom_method


Expand Down
2 changes: 1 addition & 1 deletion stripe/api_resources/issuing/cardholder.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
from __future__ import absolute_import, division, print_function

from stripe.api_resources.abstract import CreateableAPIResource
from stripe.api_resources.abstract import UpdateableAPIResource
from stripe.api_resources.abstract import ListableAPIResource
from stripe.api_resources.abstract import UpdateableAPIResource


class Cardholder(
Expand Down
Loading

0 comments on commit f51dbeb

Please sign in to comment.