Fix devnet version comes is run in wrong jobs

Saadulaev-Al · Mar 29, 2023 · e50ca91 · e50ca91
1 parent ed7d8b0
commit e50ca91
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/.github/workflows/deployments.yml b/.github/workflows/deployments.yml
@@ -13,6 +13,8 @@ jobs:
       PRIVATE_KEY: ${{ secrets.PRIVATE_KEY }}
       DEVNET_ACCOUNT_ADDRESS: ${{ secrets.DEVNET_ACCOUNT_ADDRESS }}
       DEVNET_PRIVATE_KEY: ${{ secrets.DEVNET_PRIVATE_KEY }}
+    outputs:
+      devnet-version: ${{ steps.devnet-version.outputs.DEVNET_VERSION }}
     steps:
       - uses: actions/checkout@v3
       - uses: actions/setup-python@v4
@@ -41,11 +43,14 @@ jobs:
       - name: Install dependencies
         if: steps.cached-poetry-dependencies.outputs.cache-hit != 'true'
         run: make setup
+      - name: Project devnet version
+        id: devnet-version
+        run:
+          echo "DEVNET_VERSION=`poetry run starknet-devnet --version`" >>
+          $GITHUB_OUTPUT
       - name: Deploy
         run: |
           poetry run python ./docker/devnet/run_and_deploy.py
-          STARKNET_NETWORK=testnet poetry run python ./scripts/deploy_kakarot.py
-          STARKNET_NETWORK=testnet2 poetry run python ./scripts/deploy_kakarot.py
       - name: Store deployment artifacts
         uses: actions/upload-artifact@v3
         with:
@@ -72,15 +77,12 @@ jobs:
         with:
           name: deployments
           path: deployments
-      - name: Project devnet version
-        run: poetry run starknet-devnet --version
-        id: devnet-version
       - name: Build and push
         uses: docker/build-push-action@v4
         with:
           push: true
           tags: ghcr.io/sayajin-labs/kakarot/devnet:latest
           context: .
           build-args: |
-            DEVNET_VERSION=${{ steps.devnet-version.outputs.stdout }}
+            DEVNET_VERSION=${{ needs.deploy.outputs.devnet-version }}
           file: ./docker/devnet/Dockerfile