Python: Add Hive Catalog (#5391)

.pre-commit-config.yaml

@@ -16,6 +16,7 @@
 # under the License.
 ---
 files: ^python/
+exclude: ^python/vendor/
 
 repos:
   - repo: https://github.com/pre-commit/pre-commit-hooks

LICENSE

@@ -213,3 +213,23 @@ Home page: https://avro.apache.org/
 License: https://www.apache.org/licenses/LICENSE-2.0
 
 --------------------------------------------------------------------------------
+
+This product includes code from Apache Thrift.
+
+* Uses the fb303.thrift file that's part of Hive's thrift service in vendor/fb303/
+
+Copyright: 2006-2022 The Apache Software Foundation.
+Home page: https://thrift.apache.org/
+License: https://www.apache.org/licenses/LICENSE-2.0
+
+--------------------------------------------------------------------------------
+
+This product includes code from Apache Hive.
+
+* Uses hive_metastore.thrift to generate the Hive Metastore client in vendor/hive_metastore/
+
+Copyright: 2008-2022 The Apache Software Foundation.
+Home page: https://hive.apache.org/
+License: https://www.apache.org/licenses/LICENSE-2.0
+
+--------------------------------------------------------------------------------

Makefile

@@ -17,7 +17,7 @@
 
 install:
 	pip install poetry
-	poetry install -E pyarrow
+	poetry install -E pyarrow -E hive
 
 lint:
 	poetry run pre-commit run --all-files

pyiceberg/catalog/base.py

@@ -91,7 +91,7 @@ def create_table(
     def load_table(self, identifier: str | Identifier) -> Table:
         """Loads the table's metadata and returns the table instance.
 
-        You can also use this method to check for table existence using 'try catalog.table() except TableNotFoundError'
+        You can also use this method to check for table existence using 'try catalog.table() except NoSuchTableError'
         Note: This method doesn't scan data stored in the table.
 
         Args:
@@ -166,7 +166,7 @@ def drop_namespace(self, namespace: str | Identifier) -> None:
         """
 
     @abstractmethod
-    def list_tables(self, namespace: str | Identifier | None = None) -> list[Identifier]:
+    def list_tables(self, namespace: str | Identifier) -> list[Identifier]:
         """List tables under the given namespace in the catalog.
 
         If namespace not provided, will list all tables in the catalog.