fix for latex3#423

SamuelMarks · Nov 9, 2020 · 2ca263e · 2ca263e
1 parent d3eb59e
commit 2ca263e
Show file tree

Hide file tree

Showing 6 changed files with 79 additions and 6 deletions.
diff --git a/base/changes.txt b/base/changes.txt
@@ -10,6 +10,19 @@ are not part of the distribution.
 All changes above are only part of the development branch for the next release.
 ================================================================================
 
+2020-11-09  Frank Mittelbach  <[email protected]>
+
+	* ltmath.dtx:
+	\negmedspace and \negthickspace have been only in amsmath,
+	so we need to undefine for rollback because amsmath used
+	\newcommand back then (gh/423)
+
+2020-11-09  Frank Mittelbach  <[email protected]>
+
+	* ltclass.dtx (section{Package/class rollback mechanism}):
+	Change help text for suspicous rollback, because the package may have
+        existed then --- there is just no rollback data (gh/423)
+
 #########################
 # 2020-10-01 PL 2 Release
 #########################

diff --git a/base/ltclass.dtx b/base/ltclass.dtx
@@ -33,7 +33,7 @@
 %<*driver>
 % \fi
 \ProvidesFile{ltclass.dtx}
-             [2020/10/18 v1.3t LaTeX Kernel (Class & Package Interface)]
+             [2020/11/09 v1.3u LaTeX Kernel (Class & Package Interface)]
 % \iffalse
 \documentclass{ltxdoc}
 \GetFileInfo{ltclass.dtx}
@@ -3271,19 +3271,20 @@
 %    A similar error is given if global rollback date and min-date on
 %    a specific package conflict with each other, but that case is
 %    happens only once so it is inlined.
+% \changes{v1.3u}{2020/11/09}{Change help text because the package may have
+%    existed then --- there is just no rollback data (gh/423).}
 %    \begin{macrocode}
 \def\pkgcls@rollbackdate@error#1{%
   \@latex@error{Suspicious rollback date given}%
-     {The \@cls@pkg\space'\@currname'  claims that it
-      came into existence on #1 which\MessageBreak
+     {The \@cls@pkg\space'\@currname'  has no rollback data
+      before #1 which\MessageBreak
       is after your requested rollback date --- so
-      something is wrong here.\MessageBreak
+      something may be wrong here.\MessageBreak
       Continue and we use the earliest known release.}}
 %    \end{macrocode}
 %  \end{macro}
 %
 %
-%
 %  \begin{macro}{\DeclareCurrentRelease}
 %    This declares the date (and possible name) of the current version
 %    of a package or class.

diff --git a/base/ltmath.dtx b/base/ltmath.dtx
@@ -38,7 +38,7 @@
 %<*driver>
 % \fi
 \ProvidesFile{ltmath.dtx}
-              [2020/07/27 v1.2g LaTeX Kernel (Math Setup)]
+              [2020/11/09 v1.2h LaTeX Kernel (Math Setup)]
 % \iffalse
 %</driver>
 %
@@ -593,6 +593,13 @@
 %<latexrelease>\def\;{\mskip\thickmuskip}
 %<latexrelease>\def\!{\mskip-\thinmuskip}
 %<latexrelease>
+%    \end{macrocode}
+% \changes{v1.2h}{2020/11/09}{\cs{negmedspace} and \cs{negthickspace}
+%    have been only in amsmath, so we need to undefine for rollback (gh/423)}
+%    \begin{macrocode}
+%<latexrelease>\let\negmedspace\@undefined
+%<latexrelease>\let\negthickspace\@undefined
+%<latexrelease>
 %<latexrelease>\EndIncludeInRelease
 %<*2ekernel>
 %    \end{macrocode}

diff --git a/required/amsmath/testfiles/github-0423.lvt b/required/amsmath/testfiles/github-0423.lvt
@@ -0,0 +1,17 @@
+% rollback did fail because amsmath used \newcommand :-(
+
+\RequirePackage[2018/11/01]{latexrelease}
+
+\documentclass{article}
+
+\usepackage{amsmath}
+
+\input{test2e}
+
+\START
+
+\begin{document}
+
+
+\END
+
diff --git a/required/amsmath/testfiles/github-0423.tlg b/required/amsmath/testfiles/github-0423.tlg
@@ -0,0 +1,17 @@
+This is a generated file for the LaTeX2e validation system.
+Don't change this file in any respect.
+(github-0423.aux)
+LaTeX Font Info:    Checking defaults for OML/cmm/m/it on input line ....
+LaTeX Font Info:    ... okay on input line ....
+LaTeX Font Info:    Checking defaults for OMS/cmsy/m/n on input line ....
+LaTeX Font Info:    ... okay on input line ....
+LaTeX Font Info:    Checking defaults for OT1/cmr/m/n on input line ....
+LaTeX Font Info:    ... okay on input line ....
+LaTeX Font Info:    Checking defaults for T1/cmr/m/n on input line ....
+LaTeX Font Info:    ... okay on input line ....
+LaTeX Font Info:    Checking defaults for TS1/cmr/m/n on input line ....
+LaTeX Font Info:    ... okay on input line ....
+LaTeX Font Info:    Checking defaults for OMX/cmex/m/n on input line ....
+LaTeX Font Info:    ... okay on input line ....
+LaTeX Font Info:    Checking defaults for U/cmr/m/n on input line ....
+LaTeX Font Info:    ... okay on input line ....
diff --git a/required/amsmath/testfiles/github-0423.xetex.tlg b/required/amsmath/testfiles/github-0423.xetex.tlg
@@ -0,0 +1,18 @@
+This is a generated file for the LaTeX2e validation system.
+Don't change this file in any respect.
+(github-0423.aux)
+LaTeX Font Info:    Checking defaults for OML/cmm/m/it on input line ....
+LaTeX Font Info:    ... okay on input line ....
+LaTeX Font Info:    Checking defaults for OMS/cmsy/m/n on input line ....
+LaTeX Font Info:    ... okay on input line ....
+LaTeX Font Info:    Checking defaults for OT1/cmr/m/n on input line ....
+LaTeX Font Info:    ... okay on input line ....
+LaTeX Font Info:    Checking defaults for T1/cmr/m/n on input line ....
+LaTeX Font Info:    ... okay on input line ....
+LaTeX Font Info:    Checking defaults for TS1/cmr/m/n on input line ....
+LaTeX Font Info:    ... okay on input line ....
+LaTeX Font Info:    Checking defaults for OMX/cmex/m/n on input line ....
+LaTeX Font Info:    ... okay on input line ....
+LaTeX Font Info:    Checking defaults for U/cmr/m/n on input line ....
+LaTeX Font Info:    ... okay on input line ....
+LaTeX Font Info:    Trying to load font information for TU+lmr on input line ....