input_decoder: move astream check up

Fix a potential crash when the aout is failing to initialize.
Sanjukademani · Nov 22, 2022 · caa1eaa · caa1eaa
1 parent a621913
commit caa1eaa
Showing 1 changed file with 10 additions and 11 deletions.
diff --git a/src/input/decoder.c b/src/input/decoder.c
@@ -1293,6 +1293,15 @@ static int ModuleThread_PlayAudio( vlc_input_decoder_t *p_owner, vlc_frame_t *p_
     }
 
     vlc_fifo_Lock(p_owner->p_fifo);
+    vlc_aout_stream *p_astream = p_owner->p_astream;
+    if( p_astream == NULL )
+    {
+        vlc_fifo_Unlock(p_owner->p_fifo);
+        msg_Dbg( p_dec, "discarded audio buffer" );
+        block_Release( p_audio );
+        return VLC_EGENERIC;
+    }
+
     if (p_owner->flushing)
     {
         vlc_fifo_Unlock(p_owner->p_fifo);
@@ -1315,8 +1324,7 @@ static int ModuleThread_PlayAudio( vlc_input_decoder_t *p_owner, vlc_frame_t *p_
     {
         msg_Dbg( p_dec, "end of audio preroll" );
 
-        if( p_owner->p_astream )
-            vlc_aout_stream_Flush( p_owner->p_astream );
+        vlc_aout_stream_Flush( p_astream );
     }
 
     /* */
@@ -1327,15 +1335,6 @@ static int ModuleThread_PlayAudio( vlc_input_decoder_t *p_owner, vlc_frame_t *p_
     DecoderWaitUnblock( p_owner );
     vlc_fifo_Unlock(p_owner->p_fifo);
 
-    vlc_aout_stream *p_astream = p_owner->p_astream;
-
-    if( p_astream == NULL )
-    {
-        msg_Dbg( p_dec, "discarded audio buffer" );
-        block_Release( p_audio );
-        return VLC_EGENERIC;
-    }
-
     int status = vlc_aout_stream_Play( p_astream, p_audio );
     if( status == AOUT_DEC_CHANGED )
     {