Skip to content

Commit

Permalink
Remove chunking strategy from test (#1715)
Browse files Browse the repository at this point in the history
* Remove strategy from test

* Put in chunking_strategy as a comment
  • Loading branch information
NolanTrem authored Dec 20, 2024
1 parent a4f1eda commit 6faec50
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
2 changes: 0 additions & 2 deletions py/core/database/filters.py
Original file line number Diff line number Diff line change
Expand Up @@ -423,8 +423,6 @@ def apply_filters(
builder = SQLFilterBuilder(params=params, mode=mode)
filter_clause, new_params = builder.build(expr)

print("filter_clause = ", filter_clause)

if mode == "where_clause":
return filter_clause, new_params # Already includes WHERE
elif mode == "condition_only":
Expand Down
2 changes: 1 addition & 1 deletion py/tests/integration/test_ingestion.py
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ def test_custom_ingestion_config(client: R2RClient):
custom_config = {
"provider": "r2r",
"strategy": "auto",
"chunking_strategy": "by_title",
# "chunking_strategy": "by_title", Fixme: This was not implemented in the ingestion config
"new_after_n_chars": 256,
"max_characters": 512,
"combine_under_n_chars": 64,
Expand Down

0 comments on commit 6faec50

Please sign in to comment.