Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Lazy median aggregator" #6293

Closed
wants to merge 1 commit into from
Closed

Conversation

pp-mo
Copy link
Member

@pp-mo pp-mo commented Jan 20, 2025

Reverts #6167

@pp-mo pp-mo added the benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts label Jan 20, 2025
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.85%. Comparing base (e9d3cfc) to head (6b14a74).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6293   +/-   ##
=======================================
  Coverage   89.85%   89.85%           
=======================================
  Files          88       88           
  Lines       23395    23387    -8     
  Branches     4358     4357    -1     
=======================================
- Hits        21021    21014    -7     
  Misses       1646     1646           
+ Partials      728      727    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

⏱️ Performance Benchmark Report: 2c7d89f

Performance shifts
| Change   | Before [e9d3cfc6]    | After [2c7d89f7]    |   Ratio | Benchmark (Parameter)                                           |
|----------|----------------------|---------------------|---------|-----------------------------------------------------------------|
| -        | 62.7±1ms             | 38.5±0.7ms          |    0.61 | aggregate_collapse.Aggregation.time_aggregated_by_MEDIAN(False) |
| -        | 63.9±0.5ms           | 39.5±0.3ms          |    0.62 | aggregate_collapse.Aggregation.time_aggregated_by_MEDIAN(True)  |
Full benchmark results

Benchmarks that have improved:

| Change   | Before [e9d3cfc6]    | After [2c7d89f7]    |   Ratio | Benchmark (Parameter)                                           |
|----------|----------------------|---------------------|---------|-----------------------------------------------------------------|
| -        | 62.7±1ms             | 38.5±0.7ms          |    0.61 | aggregate_collapse.Aggregation.time_aggregated_by_MEDIAN(False) |
| -        | 63.9±0.5ms           | 39.5±0.3ms          |    0.62 | aggregate_collapse.Aggregation.time_aggregated_by_MEDIAN(True)  |

Benchmarks that have stayed the same:

| Change   | Before [e9d3cfc6]    | After [2c7d89f7]    |   Ratio | Benchmark (Parameter)                                                                       |
|----------|----------------------|---------------------|---------|---------------------------------------------------------------------------------------------|
|          | 59.0±0.6ms           | 58.5±0.6ms          |    0.99 | aggregate_collapse.Aggregation.time_aggregated_by_COUNT(False)                              |
|          | 60.0±0.8ms           | 59.3±0.4ms          |    0.99 | aggregate_collapse.Aggregation.time_aggregated_by_COUNT(True)                               |
|          | 203±2ms              | 204±3ms             |    1    | aggregate_collapse.Aggregation.time_aggregated_by_FAST_PERCENTILE(False)                    |
|          | 204±2ms              | 205±1ms             |    1.01 | aggregate_collapse.Aggregation.time_aggregated_by_FAST_PERCENTILE(True)                     |
|          | 37.2±0.4ms           | 37.8±0.4ms          |    1.01 | aggregate_collapse.Aggregation.time_aggregated_by_GMEAN(False)                              |
|          | 38.4±0.4ms           | 38.6±0.4ms          |    1.01 | aggregate_collapse.Aggregation.time_aggregated_by_GMEAN(True)                               |
|          | 37.4±0.4ms           | 37.5±0.4ms          |    1    | aggregate_collapse.Aggregation.time_aggregated_by_HMEAN(False)                              |
|          | 38.4±0.5ms           | 38.3±0.4ms          |    1    | aggregate_collapse.Aggregation.time_aggregated_by_HMEAN(True)                               |
|          | 49.8±0.9ms           | 50.5±0.7ms          |    1.02 | aggregate_collapse.Aggregation.time_aggregated_by_MAX(False)                                |
|          | 51.5±0.5ms           | 52.0±0.8ms          |    1.01 | aggregate_collapse.Aggregation.time_aggregated_by_MAX(True)                                 |
|          | 132±1ms              | 133±1ms             |    1.01 | aggregate_collapse.Aggregation.time_aggregated_by_MAX_RUN(False)                            |
|          | 133±1ms              | 134±2ms             |    1.01 | aggregate_collapse.Aggregation.time_aggregated_by_MAX_RUN(True)                             |
|          | 55.9±0.5ms           | 54.9±0.9ms          |    0.98 | aggregate_collapse.Aggregation.time_aggregated_by_MEAN(False)                               |
|          | 56.5±0.3ms           | 56.1±0.8ms          |    0.99 | aggregate_collapse.Aggregation.time_aggregated_by_MEAN(True)                                |
|          | 50.4±1ms             | 51.0±0.7ms          |    1.01 | aggregate_collapse.Aggregation.time_aggregated_by_MIN(False)                                |
|          | 51.0±0.9ms           | 51.7±1ms            |    1.01 | aggregate_collapse.Aggregation.time_aggregated_by_MIN(True)                                 |
|          | 1.10±0.01s           | 1.09±0.01s          |    0.99 | aggregate_collapse.Aggregation.time_aggregated_by_PEAK(False)                               |
|          | 1.09±0.02s           | 1.10±0.01s          |    1    | aggregate_collapse.Aggregation.time_aggregated_by_PEAK(True)                                |
|          | 490±10ms             | 482±10ms            |    0.98 | aggregate_collapse.Aggregation.time_aggregated_by_PERCENTILE(False)                         |
|          | 501±10ms             | 496±20ms            |    0.99 | aggregate_collapse.Aggregation.time_aggregated_by_PERCENTILE(True)                          |
|          | 37.5±0.7ms           | 36.4±0.5ms          |    0.97 | aggregate_collapse.Aggregation.time_aggregated_by_PROPORTION(False)                         |
|          | 37.3±0.4ms           | 37.0±0.3ms          |    0.99 | aggregate_collapse.Aggregation.time_aggregated_by_PROPORTION(True)                          |
|          | 66.3±0.7ms           | 65.3±0.8ms          |    0.99 | aggregate_collapse.Aggregation.time_aggregated_by_RMS(False)                                |
|          | 67.2±0.7ms           | 66.9±0.7ms          |    0.99 | aggregate_collapse.Aggregation.time_aggregated_by_RMS(True)                                 |
|          | 70.3±0.7ms           | 69.7±0.9ms          |    0.99 | aggregate_collapse.Aggregation.time_aggregated_by_STD_DEV(False)                            |
|          | 70.9±0.5ms           | 70.3±0.8ms          |    0.99 | aggregate_collapse.Aggregation.time_aggregated_by_STD_DEV(True)                             |
|          | 64.7±0.7ms           | 64.8±0.5ms          |    1    | aggregate_collapse.Aggregation.time_aggregated_by_VARIANCE(False)                           |
|          | 65.6±0.6ms           | 65.8±1ms            |    1    | aggregate_collapse.Aggregation.time_aggregated_by_VARIANCE(True)                            |
|          | 25.2±0.3ms           | 25.3±0.4ms          |    1    | aggregate_collapse.Aggregation.time_collapsed_by_COUNT(False)                               |
|          | 29.4±0.5ms           | 29.5±0.4ms          |    1    | aggregate_collapse.Aggregation.time_collapsed_by_COUNT(True)                                |
|          | 139±2ms              | 138±2ms             |    0.99 | aggregate_collapse.Aggregation.time_collapsed_by_FAST_PERCENTILE(False)                     |
|          | 153±2ms              | 153±1ms             |    1    | aggregate_collapse.Aggregation.time_collapsed_by_FAST_PERCENTILE(True)                      |
|          | 23.3±0.5ms           | 23.3±0.5ms          |    1    | aggregate_collapse.Aggregation.time_collapsed_by_GMEAN(False)                               |
|          | 27.7±0.4ms           | 27.6±0.7ms          |    1    | aggregate_collapse.Aggregation.time_collapsed_by_GMEAN(True)                                |
|          | 23.0±0.3ms           | 23.2±0.5ms          |    1.01 | aggregate_collapse.Aggregation.time_collapsed_by_HMEAN(False)                               |
|          | 27.5±0.6ms           | 27.4±0.5ms          |    0.99 | aggregate_collapse.Aggregation.time_collapsed_by_HMEAN(True)                                |
|          | 24.0±0.5ms           | 24.1±0.2ms          |    1    | aggregate_collapse.Aggregation.time_collapsed_by_MAX(False)                                 |
|          | 28.2±0.4ms           | 28.4±0.2ms          |    1.01 | aggregate_collapse.Aggregation.time_collapsed_by_MAX(True)                                  |
|          | 36.8±0.3ms           | 36.4±0.7ms          |    0.99 | aggregate_collapse.Aggregation.time_collapsed_by_MAX_RUN(False)                             |
|          | 41.5±0.4ms           | 40.7±0.4ms          |    0.98 | aggregate_collapse.Aggregation.time_collapsed_by_MAX_RUN(True)                              |
|          | 24.8±0.4ms           | 24.2±0.3ms          |    0.98 | aggregate_collapse.Aggregation.time_collapsed_by_MEAN(False)                                |
|          | 29.2±0.2ms           | 28.4±0.4ms          |    0.97 | aggregate_collapse.Aggregation.time_collapsed_by_MEAN(True)                                 |
|          | 27.0±0.6ms           | 24.3±0.2ms          |    0.9  | aggregate_collapse.Aggregation.time_collapsed_by_MEDIAN(False)                              |
|          | 31.5±0.5ms           | 28.7±0.4ms          |    0.91 | aggregate_collapse.Aggregation.time_collapsed_by_MEDIAN(True)                               |
|          | 24.5±0.5ms           | 24.1±0.4ms          |    0.98 | aggregate_collapse.Aggregation.time_collapsed_by_MIN(False)                                 |
|          | 28.7±0.4ms           | 28.3±0.4ms          |    0.98 | aggregate_collapse.Aggregation.time_collapsed_by_MIN(True)                                  |
|          | 546±3ms              | 553±4ms             |    1.01 | aggregate_collapse.Aggregation.time_collapsed_by_PEAK(False)                                |
|          | 556±3ms              | 550±4ms             |    0.99 | aggregate_collapse.Aggregation.time_collapsed_by_PEAK(True)                                 |
|          | 154±2ms              | 152±1ms             |    0.99 | aggregate_collapse.Aggregation.time_collapsed_by_PERCENTILE(False)                          |
|          | 170±2ms              | 171±1ms             |    1    | aggregate_collapse.Aggregation.time_collapsed_by_PERCENTILE(True)                           |
|          | 23.4±0.5ms           | 22.8±0.4ms          |    0.97 | aggregate_collapse.Aggregation.time_collapsed_by_PROPORTION(False)                          |
|          | 27.6±0.3ms           | 27.1±0.8ms          |    0.98 | aggregate_collapse.Aggregation.time_collapsed_by_PROPORTION(True)                           |
|          | 26.4±0.4ms           | 26.3±0.2ms          |    1    | aggregate_collapse.Aggregation.time_collapsed_by_RMS(False)                                 |
|          | 30.6±0.6ms           | 30.4±0.4ms          |    0.99 | aggregate_collapse.Aggregation.time_collapsed_by_RMS(True)                                  |
|          | 25.8±0.3ms           | 25.7±0.3ms          |    1    | aggregate_collapse.Aggregation.time_collapsed_by_STD_DEV(False)                             |
|          | 29.9±0.5ms           | 30.4±0.5ms          |    1.02 | aggregate_collapse.Aggregation.time_collapsed_by_STD_DEV(True)                              |
|          | 25.4±0.3ms           | 25.2±0.4ms          |    0.99 | aggregate_collapse.Aggregation.time_collapsed_by_VARIANCE(False)                            |
|          | 29.6±0.5ms           | 29.6±0.3ms          |    1    | aggregate_collapse.Aggregation.time_collapsed_by_VARIANCE(True)                             |
|          | 91.1±0.7ms           | 90.9±0.8ms          |    1    | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_MEAN(False)                     |
|          | 90.2±1ms             | 92.6±1ms            |    1.03 | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_MEAN(True)                      |
|          | 103±0.6ms            | 103±1ms             |    1    | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_RMS(False)                      |
|          | 103±1ms              | 103±1ms             |    1    | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_RMS(True)                       |
|          | 61.5±0.5ms           | 61.3±0.8ms          |    1    | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_SUM(False)                      |
|          | 62.1±0.7ms           | 62.3±0.4ms          |    1    | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_SUM(True)                       |
|          | 30.2±0.4ms           | 30.0±0.5ms          |    0.99 | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_MEAN(False)                      |
|          | 34.7±0.6ms           | 34.2±0.4ms          |    0.99 | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_MEAN(True)                       |
|          | 31.7±0.6ms           | 31.6±0.3ms          |    1    | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_RMS(False)                       |
|          | 35.8±0.6ms           | 36.0±0.4ms          |    1    | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_RMS(True)                        |
|          | 25.8±0.3ms           | 26.0±0.2ms          |    1.01 | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_SUM(False)                       |
|          | 30.1±0.3ms           | 30.3±0.4ms          |    1.01 | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_SUM(True)                        |
|          | 313±4ms              | 314±3ms             |    1    | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_WPERCENTILE(False)               |
|          | 336±5ms              | 337±3ms             |    1    | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_WPERCENTILE(True)                |
|          | 1.13±0.01ms          | 1.12±0.02ms         |    1    | cube.CubeCreation.time_create(False, 'construct')                                           |
|          | 397±3μs              | 403±6μs             |    1.01 | cube.CubeCreation.time_create(False, 'instantiate')                                         |
|          | 967±10μs             | 949±10μs            |    0.98 | cube.CubeCreation.time_create(True, 'construct')                                            |
|          | 574±10μs             | 585±5μs             |    1.02 | cube.CubeCreation.time_create(True, 'instantiate')                                          |
|          | 232±4ms              | 235±3ms             |    1.01 | cube.CubeEquality.time_equality(False, False, 'all_equal')                                  |
|          | 123±2ms              | 122±2ms             |    0.99 | cube.CubeEquality.time_equality(False, False, 'coord_inequality')                           |
|          | 261±3ms              | 258±2ms             |    0.99 | cube.CubeEquality.time_equality(False, False, 'data_inequality')                            |
|          | 17.1±0.3μs           | 17.0±0.2μs          |    1    | cube.CubeEquality.time_equality(False, False, 'metadata_inequality')                        |
|          | 327±2ms              | 327±2ms             |    1    | cube.CubeEquality.time_equality(False, True, 'all_equal')                                   |
|          | 215±2ms              | 215±2ms             |    1    | cube.CubeEquality.time_equality(False, True, 'coord_inequality')                            |
|          | 352±3ms              | 351±3ms             |    1    | cube.CubeEquality.time_equality(False, True, 'data_inequality')                             |
|          | 17.3±0.05μs          | 17.1±0.2μs          |    0.98 | cube.CubeEquality.time_equality(False, True, 'metadata_inequality')                         |
|          | 233±2ms              | 233±3ms             |    1    | cube.CubeEquality.time_equality(True, False, 'all_equal')                                   |
|          | 123±1ms              | 123±3ms             |    1    | cube.CubeEquality.time_equality(True, False, 'coord_inequality')                            |
|          | 261±4ms              | 258±2ms             |    0.99 | cube.CubeEquality.time_equality(True, False, 'data_inequality')                             |
|          | 54.5±0.9μs           | 53.3±0.5μs          |    0.98 | cube.CubeEquality.time_equality(True, False, 'metadata_inequality')                         |
|          | 328±4ms              | 327±5ms             |    1    | cube.CubeEquality.time_equality(True, True, 'all_equal')                                    |
|          | 214±1ms              | 217±2ms             |    1.01 | cube.CubeEquality.time_equality(True, True, 'coord_inequality')                             |
|          | 351±3ms              | 351±3ms             |    1    | cube.CubeEquality.time_equality(True, True, 'data_inequality')                              |
|          | 56.0±0.3μs           | 55.0±0.9μs          |    0.98 | cube.CubeEquality.time_equality(True, True, 'metadata_inequality')                          |
|          | 797±5μs              | 788±6μs             |    0.99 | import_iris.Iris.time__concatenate                                                          |
|          | 182±5μs              | 176±3μs             |    0.97 | import_iris.Iris.time__constraints                                                          |
|          | 109±1μs              | 109±1μs             |    1    | import_iris.Iris.time__data_manager                                                         |
|          | 92.3±0.7μs           | 91.0±0.8μs          |    0.99 | import_iris.Iris.time__deprecation                                                          |
|          | 135±0.8μs            | 136±3μs             |    1.01 | import_iris.Iris.time__lazy_data                                                            |
|          | 934±9μs              | 916±20μs            |    0.98 | import_iris.Iris.time__merge                                                                |
|          | 74.7±0.5μs           | 75.3±1μs            |    1.01 | import_iris.Iris.time__representation                                                       |
|          | 595±5μs              | 595±3μs             |    1    | import_iris.Iris.time_analysis                                                              |
|          | 139±2μs              | 138±2μs             |    0.99 | import_iris.Iris.time_analysis__area_weighted                                               |
|          | 108±1μs              | 108±0.6μs           |    1    | import_iris.Iris.time_analysis__grid_angles                                                 |
|          | 243±4μs              | 242±4μs             |    1    | import_iris.Iris.time_analysis__interpolation                                               |
|          | 187±1μs              | 186±1μs             |    1    | import_iris.Iris.time_analysis__regrid                                                      |
|          | 109±0.8μs            | 109±0.6μs           |    1    | import_iris.Iris.time_analysis__scipy_interpolate                                           |
|          | 138±1μs              | 138±1μs             |    1    | import_iris.Iris.time_analysis_calculus                                                     |
|          | 333±3μs              | 333±3μs             |    1    | import_iris.Iris.time_analysis_cartography                                                  |
|          | 93.5±0.6μs           | 92.1±0.5μs          |    0.98 | import_iris.Iris.time_analysis_geomerty                                                     |
|          | 217±3μs              | 219±4μs             |    1.01 | import_iris.Iris.time_analysis_maths                                                        |
|          | 95.5±1μs             | 95.4±0.4μs          |    1    | import_iris.Iris.time_analysis_stats                                                        |
|          | 173±2μs              | 170±2μs             |    0.98 | import_iris.Iris.time_analysis_trajectory                                                   |
|          | 308±3μs              | 314±5μs             |    1.02 | import_iris.Iris.time_aux_factory                                                           |
|          | 82.3±0.4μs           | 82.2±0.7μs          |    1    | import_iris.Iris.time_common                                                                |
|          | 161±3μs              | 160±3μs             |    1    | import_iris.Iris.time_common_lenient                                                        |
|          | 1.36±0.02ms          | 1.36±0.03ms         |    1    | import_iris.Iris.time_common_metadata                                                       |
|          | 163±3μs              | 166±4μs             |    1.02 | import_iris.Iris.time_common_mixin                                                          |
|          | 1.20±0.01ms          | 1.21±0.01ms         |    1.01 | import_iris.Iris.time_common_resolve                                                        |
|          | 198±1μs              | 195±1μs             |    0.99 | import_iris.Iris.time_config                                                                |
|          | 123±2μs              | 122±1μs             |    0.99 | import_iris.Iris.time_coord_categorisation                                                  |
|          | 369±3μs              | 363±4μs             |    0.98 | import_iris.Iris.time_coord_systems                                                         |
|          | 762±8μs              | 758±8μs             |    0.99 | import_iris.Iris.time_coords                                                                |
|          | 666±5μs              | 659±9μs             |    0.99 | import_iris.Iris.time_cube                                                                  |
|          | 219±4μs              | 221±5μs             |    1.01 | import_iris.Iris.time_exceptions                                                            |
|          | 75.5±0.4μs           | 75.1±0.3μs          |    0.99 | import_iris.Iris.time_experimental                                                          |
|          | 183±4μs              | 183±1μs             |    1    | import_iris.Iris.time_fileformats                                                           |
|          | 252±2μs              | 249±5μs             |    0.99 | import_iris.Iris.time_fileformats__ff                                                       |
|          | 2.66±0.01ms          | 2.68±0.02ms         |    1.01 | import_iris.Iris.time_fileformats__ff_cross_references                                      |
|          | 77.2±2μs             | 77.7±0.4μs          |    1.01 | import_iris.Iris.time_fileformats__pp_lbproc_pairs                                          |
|          | 112±3μs              | 112±2μs             |    1    | import_iris.Iris.time_fileformats_abf                                                       |
|          | 423±7μs              | 410±5μs             |    0.97 | import_iris.Iris.time_fileformats_cf                                                        |
|          | 4.80±0.01ms          | 4.83±0.02ms         |    1.01 | import_iris.Iris.time_fileformats_dot                                                       |
|          | 73.3±0.7μs           | 73.6±0.4μs          |    1    | import_iris.Iris.time_fileformats_name                                                      |
|          | 256±2μs              | 262±6μs             |    1.02 | import_iris.Iris.time_fileformats_name_loaders                                              |
|          | 116±1μs              | 117±1μs             |    1.01 | import_iris.Iris.time_fileformats_netcdf                                                    |
|          | 122±1μs              | 122±1μs             |    0.99 | import_iris.Iris.time_fileformats_nimrod                                                    |
|          | 211±1μs              | 208±2μs             |    0.99 | import_iris.Iris.time_fileformats_nimrod_load_rules                                         |
|          | 792±3μs              | 792±10μs            |    1    | import_iris.Iris.time_fileformats_pp                                                        |
|          | 190±6μs              | 181±2μs             |    0.95 | import_iris.Iris.time_fileformats_pp_load_rules                                             |
|          | 131±2μs              | 137±6μs             |    1.04 | import_iris.Iris.time_fileformats_pp_save_rules                                             |
|          | 554±10μs             | 549±2μs             |    0.99 | import_iris.Iris.time_fileformats_rules                                                     |
|          | 222±7μs              | 216±2μs             |    0.97 | import_iris.Iris.time_fileformats_structured_array_identification                           |
|          | 83.4±1μs             | 82.1±0.3μs          |    0.98 | import_iris.Iris.time_fileformats_um                                                        |
|          | 160±2μs              | 160±1μs             |    1    | import_iris.Iris.time_fileformats_um__fast_load                                             |
|          | 136±0.7μs            | 137±1μs             |    1.01 | import_iris.Iris.time_fileformats_um__fast_load_structured_fields                           |
|          | 73.9±0.5μs           | 74.2±0.5μs          |    1    | import_iris.Iris.time_fileformats_um__ff_replacement                                        |
|          | 79.6±0.2μs           | 80.6±0.5μs          |    1.01 | import_iris.Iris.time_fileformats_um__optimal_array_structuring                             |
|          | 974±4μs              | 984±9μs             |    1.01 | import_iris.Iris.time_fileformats_um_cf_map                                                 |
|          | 134±0.7μs            | 134±0.6μs           |    1    | import_iris.Iris.time_io                                                                    |
|          | 174±0.9μs            | 169±4μs             |    0.97 | import_iris.Iris.time_io_format_picker                                                      |
|          | 296±4μs              | 290±5μs             |    0.98 | import_iris.Iris.time_iris                                                                  |
|          | 127±0.9μs            | 124±1μs             |    0.98 | import_iris.Iris.time_iterate                                                               |
|          | 8.20±0.06ms          | 8.20±0.06ms         |    1    | import_iris.Iris.time_palette                                                               |
|          | 1.93±0.01ms          | 1.91±0.02ms         |    0.99 | import_iris.Iris.time_plot                                                                  |
|          | 102±0.4μs            | 105±1μs             |    1.02 | import_iris.Iris.time_quickplot                                                             |
|          | 2.18±0.03ms          | 2.22±0.02ms         |    1.02 | import_iris.Iris.time_std_names                                                             |
|          | 1.79±0.02ms          | 1.78±0.02ms         |    0.99 | import_iris.Iris.time_symbols                                                               |
|          | 33.2±0.6ms           | 33.9±2ms            |    1.02 | import_iris.Iris.time_tests                                                                 |
|          | 268±2μs              | 271±6μs             |    1.01 | import_iris.Iris.time_third_party_cartopy                                                   |
|          | 4.94±0.04ms          | 4.94±0.03ms         |    1    | import_iris.Iris.time_third_party_cf_units                                                  |
|          | 124±0.4μs            | 123±0.7μs           |    0.99 | import_iris.Iris.time_third_party_cftime                                                    |
|          | 2.93±0.02ms          | 2.94±0.03ms         |    1    | import_iris.Iris.time_third_party_matplotlib                                                |
|          | 1.38±0.03ms          | 1.39±0.01ms         |    1    | import_iris.Iris.time_third_party_numpy                                                     |
|          | 177±0.8μs            | 177±1μs             |    1    | import_iris.Iris.time_third_party_scipy                                                     |
|          | 98.7±0.5μs           | 99.1±2μs            |    1    | import_iris.Iris.time_time                                                                  |
|          | 341±3μs              | 345±10μs            |    1.01 | import_iris.Iris.time_util                                                                  |
|          | 72.1±0.9μs           | 71.7±1μs            |    1    | iterate.IZip.time_izip                                                                      |
|          | 10.1±0.04ms          | 10.1±0.09ms         |    1    | load.LoadAndRealise.time_load((1280, 960, 5), False, 'FF')                                  |
|          | 25.3±0.5ms           | 26.0±0.3ms          |    1.03 | load.LoadAndRealise.time_load((1280, 960, 5), False, 'NetCDF')                              |
|          | 10.2±0.05ms          | 10.1±0.07ms         |    0.99 | load.LoadAndRealise.time_load((1280, 960, 5), False, 'PP')                                  |
|          | 10.2±0.1ms           | 10.1±0.07ms         |    0.99 | load.LoadAndRealise.time_load((1280, 960, 5), True, 'FF')                                   |
|          | 22.5±0.2ms           | 22.8±0.1ms          |    1.01 | load.LoadAndRealise.time_load((1280, 960, 5), True, 'NetCDF')                               |
|          | 10.2±0.03ms          | 10.2±0.09ms         |    1    | load.LoadAndRealise.time_load((1280, 960, 5), True, 'PP')                                   |
|          | 1.61±0.01s           | 1.62±0.01s          |    1.01 | load.LoadAndRealise.time_load((2, 2, 1000), False, 'FF')                                    |
|          | 23.1±0.4ms           | 23.1±0.1ms          |    1    | load.LoadAndRealise.time_load((2, 2, 1000), False, 'NetCDF')                                |
|          | 1.64±0.02s           | 1.61±0.01s          |    0.99 | load.LoadAndRealise.time_load((2, 2, 1000), False, 'PP')                                    |
|          | 1.61±0.01s           | 1.62±0.01s          |    1.01 | load.LoadAndRealise.time_load((2, 2, 1000), True, 'FF')                                     |
|          | 22.8±0.1ms           | 23.3±0.4ms          |    1.02 | load.LoadAndRealise.time_load((2, 2, 1000), True, 'NetCDF')                                 |
|          | 1.62±0.01s           | 1.64±0.02s          |    1.02 | load.LoadAndRealise.time_load((2, 2, 1000), True, 'PP')                                     |
|          | 5.17±0.03ms          | 5.22±0.07ms         |    1.01 | load.LoadAndRealise.time_load((50, 50, 2), False, 'FF')                                     |
|          | 21.4±0.2ms           | 21.4±0.1ms          |    1    | load.LoadAndRealise.time_load((50, 50, 2), False, 'NetCDF')                                 |
|          | 5.13±0.03ms          | 5.19±0.06ms         |    1.01 | load.LoadAndRealise.time_load((50, 50, 2), False, 'PP')                                     |
|          | 5.17±0.04ms          | 5.22±0.03ms         |    1.01 | load.LoadAndRealise.time_load((50, 50, 2), True, 'FF')                                      |
|          | 21.1±0.3ms           | 21.2±0.2ms          |    1.01 | load.LoadAndRealise.time_load((50, 50, 2), True, 'NetCDF')                                  |
|          | 5.19±0.03ms          | 5.23±0.1ms          |    1.01 | load.LoadAndRealise.time_load((50, 50, 2), True, 'PP')                                      |
|          | 23.3±2ms             | 23.0±1ms            |    0.99 | load.LoadAndRealise.time_realise((1280, 960, 5), False, 'FF')                               |
|          | 19.8±0.2ms           | 20.3±0.3ms          |    1.02 | load.LoadAndRealise.time_realise((1280, 960, 5), False, 'NetCDF')                           |
|          | 11.5±0.9ms           | 11.9±0.5ms          |    1.03 | load.LoadAndRealise.time_realise((1280, 960, 5), False, 'PP')                               |
|          | 26.7±0.4ms           | 27.1±0.6ms          |    1.02 | load.LoadAndRealise.time_realise((1280, 960, 5), True, 'FF')                                |
|          | 69.0±0.7ms           | 69.2±1ms            |    1    | load.LoadAndRealise.time_realise((1280, 960, 5), True, 'NetCDF')                            |
|          | 26.2±0.7ms           | 26.8±0.8ms          |    1.02 | load.LoadAndRealise.time_realise((1280, 960, 5), True, 'PP')                                |
|          | 493±5ms              | 492±4ms             |    1    | load.LoadAndRealise.time_realise((2, 2, 1000), False, 'FF')                                 |
|          | 2.97±0.05ms          | 3.00±0.08ms         |    1.01 | load.LoadAndRealise.time_realise((2, 2, 1000), False, 'NetCDF')                             |
|          | 492±3ms              | 493±4ms             |    1    | load.LoadAndRealise.time_realise((2, 2, 1000), False, 'PP')                                 |
|          | 503±2ms              | 506±4ms             |    1.01 | load.LoadAndRealise.time_realise((2, 2, 1000), True, 'FF')                                  |
|          | 3.06±0.09ms          | 2.96±0.1ms          |    0.96 | load.LoadAndRealise.time_realise((2, 2, 1000), True, 'NetCDF')                              |
|          | 500±4ms              | 502±4ms             |    1    | load.LoadAndRealise.time_realise((2, 2, 1000), True, 'PP')                                  |
|          | 1.71±0.07ms          | 1.69±0.05ms         |    0.99 | load.LoadAndRealise.time_realise((50, 50, 2), False, 'FF')                                  |
|          | 2.98±0.07ms          | 3.21±0.04ms         |    1.08 | load.LoadAndRealise.time_realise((50, 50, 2), False, 'NetCDF')                              |
|          | 1.61±0.06ms          | 1.78±0.2ms          |    1.1  | load.LoadAndRealise.time_realise((50, 50, 2), False, 'PP')                                  |
|          | 1.71±0.09ms          | 1.75±0.08ms         |    1.02 | load.LoadAndRealise.time_realise((50, 50, 2), True, 'FF')                                   |
|          | 3.19±0.09ms          | 3.19±0.1ms          |    1    | load.LoadAndRealise.time_realise((50, 50, 2), True, 'NetCDF')                               |
|          | 1.70±0.08ms          | 1.72±0.02ms         |    1.01 | load.LoadAndRealise.time_realise((50, 50, 2), True, 'PP')                                   |
|          | 363±2ms              | 373±5ms             |    1.03 | load.ManyVars.time_many_var_load                                                            |
|          | 10.3±0.2ms           | 10.3±0.1ms          |    1.01 | load.STASHConstraint.time_stash_constraint((1280, 960, 5), 'FF')                            |
|          | 10.3±0.2ms           | 10.5±0.1ms          |    1.01 | load.STASHConstraint.time_stash_constraint((1280, 960, 5), 'PP')                            |
|          | 1.63±0.01s           | 1.63±0.01s          |    1    | load.STASHConstraint.time_stash_constraint((2, 2, 1000), 'FF')                              |
|          | 1.64±0.02s           | 1.65±0.01s          |    1    | load.STASHConstraint.time_stash_constraint((2, 2, 1000), 'PP')                              |
|          | 5.26±0.07ms          | 5.23±0.1ms          |    0.99 | load.STASHConstraint.time_stash_constraint((2, 2, 2), 'FF')                                 |
|          | 5.19±0.04ms          | 5.23±0.05ms         |    1.01 | load.STASHConstraint.time_stash_constraint((2, 2, 2), 'PP')                                 |
|          | 9.32±0.08ms          | 9.32±0.05ms         |    1    | load.StructuredFF.time_structured_load((1280, 960, 5), False)                               |
|          | 5.97±0.06ms          | 6.03±0.05ms         |    1.01 | load.StructuredFF.time_structured_load((1280, 960, 5), True)                                |
|          | 1.60±0.01s           | 1.62±0.01s          |    1.01 | load.StructuredFF.time_structured_load((2, 2, 1000), False)                                 |
|          | 559±6ms              | 559±10ms            |    1    | load.StructuredFF.time_structured_load((2, 2, 1000), True)                                  |
|          | 4.45±0.02ms          | 4.48±0.06ms         |    1.01 | load.StructuredFF.time_structured_load((2, 2, 2), False)                                    |
|          | 4.26±0.01ms          | 4.24±0.01ms         |    0.99 | load.StructuredFF.time_structured_load((2, 2, 2), True)                                     |
|          | 171±1ms              | 173±2ms             |    1.01 | load.TimeConstraint.time_time_constraint(20, 'FF')                                          |
|          | 24.8±0.4ms           | 25.2±0.1ms          |    1.01 | load.TimeConstraint.time_time_constraint(20, 'NetCDF')                                      |
|          | 175±3ms              | 176±1ms             |    1    | load.TimeConstraint.time_time_constraint(20, 'PP')                                          |
|          | 34.0±0.3ms           | 34.8±0.4ms          |    1.02 | load.TimeConstraint.time_time_constraint(3, 'FF')                                           |
|          | 24.3±0.4ms           | 24.8±0.7ms          |    1.02 | load.TimeConstraint.time_time_constraint(3, 'NetCDF')                                       |
|          | 33.9±0.9ms           | 34.1±0.7ms          |    1.01 | load.TimeConstraint.time_time_constraint(3, 'PP')                                           |
|          | 19.7±0.3ms           | 19.4±0.5ms          |    0.99 | load.ugrid.BasicLoading.time_load_file(1)                                                   |
|          | 55.4±0.9ms           | 55.9±0.4ms          |    1.01 | load.ugrid.BasicLoading.time_load_file(200000)                                              |
|          | 14.9±0.3ms           | 14.8±0.2ms          |    1    | load.ugrid.BasicLoading.time_load_mesh(1)                                                   |
|          | 24.5±0.4ms           | 24.2±0.4ms          |    0.99 | load.ugrid.BasicLoading.time_load_mesh(200000)                                              |
|          | 19.3±0.4ms           | 19.4±0.2ms          |    1.01 | load.ugrid.BasicLoadingTime.time_load_file(1)                                               |
|          | 22.9±0.3ms           | 22.5±0.4ms          |    0.98 | load.ugrid.BasicLoadingTime.time_load_file(200000)                                          |
|          | 14.7±0.2ms           | 15.2±0.3ms          |    1.04 | load.ugrid.BasicLoadingTime.time_load_mesh(1)                                               |
|          | 17.9±0.3ms           | 18.2±0.3ms          |    1.02 | load.ugrid.BasicLoadingTime.time_load_mesh(200000)                                          |
|          | 20.7±0.3ms           | 20.6±0.4ms          |    1    | load.ugrid.Callback.time_load_file_callback(1)                                              |
|          | 65.7±0.6ms           | 66.3±0.5ms          |    1.01 | load.ugrid.Callback.time_load_file_callback(200000)                                         |
|          | 20.3±0.3ms           | 20.7±0.2ms          |    1.02 | load.ugrid.CallbackTime.time_load_file_callback(1)                                          |
|          | 24.6±0.4ms           | 25.0±0.4ms          |    1.02 | load.ugrid.CallbackTime.time_load_file_callback(200000)                                     |
|          | 3.05±0.1ms           | 3.05±0.1ms          |    1    | load.ugrid.DataRealisation.time_realise_data(10000)                                         |
|          | 4.29±0.1ms           | 4.22±0.1ms          |    0.98 | load.ugrid.DataRealisation.time_realise_data(200000)                                        |
|          | 37.6±2ms             | 38.4±2ms            |    1.02 | load.ugrid.DataRealisationTime.time_realise_data(10000)                                     |
|          | 800±10ms             | 802±6ms             |    1    | load.ugrid.DataRealisationTime.time_realise_data(200000)                                    |
|          | 440±4ms              | 439±4ms             |    1    | merge_concat.Concatenate.time_concatenate(False)                                            |
|          | 444±5ms              | 439±3ms             |    0.99 | merge_concat.Concatenate.time_concatenate(True)                                             |
|          | 109±0.5M             | 109±0.2M            |    1    | merge_concat.Concatenate.tracemalloc_concatenate(False)                                     |
|          | 109±0.5M             | 109±0.3M            |    1    | merge_concat.Concatenate.tracemalloc_concatenate(True)                                      |
|          | 50.5±0.6ms           | 50.7±0.4ms          |    1    | merge_concat.Merge.time_merge                                                               |
|          | 1.62±0.2M            | 1.62±0.2M           |    1    | merge_concat.Merge.tracemalloc_merge                                                        |
|          | 405±4ns              | 421±5ns             |    1.04 | mesh.utils.regions_combine.CombineRegionsComputeRealData.time_compute_data(50)              |
|          | 214±1ms              | 213±1ms             |    1    | mesh.utils.regions_combine.CombineRegionsComputeRealData.time_compute_data(500)             |
|          | 650±0.3k             | 650±0.3k            |    1    | mesh.utils.regions_combine.CombineRegionsComputeRealData.tracemalloc_compute_data(50)       |
|          | 60.1±0M              | 60±0M               |    1    | mesh.utils.regions_combine.CombineRegionsComputeRealData.tracemalloc_compute_data(500)      |
|          | 17.6±0.3ms           | 17.8±0.2ms          |    1.01 | mesh.utils.regions_combine.CombineRegionsCreateCube.time_create_combined_cube(50)           |
|          | 20.1±0.3ms           | 20.1±0.2ms          |    1    | mesh.utils.regions_combine.CombineRegionsCreateCube.time_create_combined_cube(500)          |
|          | 698±50k              | 698±50k             |    1    | mesh.utils.regions_combine.CombineRegionsCreateCube.tracemalloc_create_combined_cube(50)    |
|          | 12.6±0.05M           | 12.6±0.05M          |    1    | mesh.utils.regions_combine.CombineRegionsCreateCube.tracemalloc_create_combined_cube(500)   |
|          | 110±1ms              | 108±3ms             |    0.98 | mesh.utils.regions_combine.CombineRegionsFileStreamedCalc.time_stream_file2file(50)         |
|          | 599±3ms              | 603±3ms             |    1.01 | mesh.utils.regions_combine.CombineRegionsFileStreamedCalc.time_stream_file2file(500)        |
|          | 1.24±0.03M           | 1.23±0.04M          |    0.99 | mesh.utils.regions_combine.CombineRegionsFileStreamedCalc.tracemalloc_stream_file2file(50)  |
|          | 96.3±0.04M           | 96.3±0.03M          |    1    | mesh.utils.regions_combine.CombineRegionsFileStreamedCalc.tracemalloc_stream_file2file(500) |
|          | 68.7±0.6ms           | 68.5±1ms            |    1    | mesh.utils.regions_combine.CombineRegionsSaveData.time_save(50)                             |
|          | 548±5ms              | 549±4ms             |    1    | mesh.utils.regions_combine.CombineRegionsSaveData.time_save(500)                            |
|          | 1.17±0.01M           | 1.17±0.01M          |    1    | mesh.utils.regions_combine.CombineRegionsSaveData.tracemalloc_save(50)                      |
|          | 96.2±0.01M           | 96.2±0.01M          |    1    | mesh.utils.regions_combine.CombineRegionsSaveData.tracemalloc_save(500)                     |
|          | 2.1752849999999997   | 2.1752849999999997  |    1    | mesh.utils.regions_combine.CombineRegionsSaveData.track_filesize_saved(50)                  |
|          | 216.01528499999998   | 216.01528499999998  |    1    | mesh.utils.regions_combine.CombineRegionsSaveData.track_filesize_saved(500)                 |
|          | 6.58±0.03ms          | 6.70±0.09ms         |    1.02 | plot.AuxSort.time_aux_sort                                                                  |
|          | 77.4±3ms             | 77.4±4ms            |    1    | regridding.CurvilinearRegridding.time_regrid_pic                                            |
|          | 136±3M               | 136±3M              |    1    | regridding.CurvilinearRegridding.tracemalloc_regrid_pic                                     |
|          | 101±0.8ms            | 100±0.5ms           |    0.99 | regridding.HorizontalChunkedRegridding.time_regrid_area_w                                   |
|          | 49.6±1ms             | 49.4±0.9ms          |    1    | regridding.HorizontalChunkedRegridding.time_regrid_area_w_new_grid                          |
|          | 106±0.04M            | 106±0.05M           |    1    | regridding.HorizontalChunkedRegridding.tracemalloc_regrid_area_w                            |
|          | 147±0.02M            | 147±0.02M           |    1    | regridding.HorizontalChunkedRegridding.tracemalloc_regrid_area_w_new_grid                   |
|          | 4.45±0.07ms          | 4.58±0.05ms         |    1.03 | save.NetcdfSave.time_netcdf_save_cube(50, False)                                            |
|          | 75.6±0.5ms           | 75.9±1ms            |    1    | save.NetcdfSave.time_netcdf_save_cube(50, True)                                             |
|          | 42.9±0.3ms           | 43.0±0.5ms          |    1    | save.NetcdfSave.time_netcdf_save_cube(600, False)                                           |
|          | 487±10ms             | 484±4ms             |    0.99 | save.NetcdfSave.time_netcdf_save_cube(600, True)                                            |
|          | 88.6±1ns             | 87.8±0.7ns          |    0.99 | save.NetcdfSave.time_netcdf_save_mesh(50, False)                                            |
|          | 56.5±1ms             | 57.1±0.8ms          |    1.01 | save.NetcdfSave.time_netcdf_save_mesh(50, True)                                             |
|          | 87.4±0.9ns           | 87.4±0.2ns          |    1    | save.NetcdfSave.time_netcdf_save_mesh(600, False)                                           |
|          | 426±3ms              | 426±3ms             |    1    | save.NetcdfSave.time_netcdf_save_mesh(600, True)                                            |
|          | 30.3±0.08k           | 30.3±0.09k          |    1    | save.NetcdfSave.tracemalloc_netcdf_save(50, False)                                          |
|          | 1.74±0.2M            | 1.71±0.2M           |    0.98 | save.NetcdfSave.tracemalloc_netcdf_save(50, True)                                           |
|          | 30.3±0.08k           | 30.2±0.09k          |    1    | save.NetcdfSave.tracemalloc_netcdf_save(600, False)                                         |
|          | 190±20M              | 225±20M             |    1.18 | save.NetcdfSave.tracemalloc_netcdf_save(600, True)                                          |
|          | 41.1±0.5ms           | 41.3±0.6ms          |    1    | stats.PearsonR.time_lazy                                                                    |
|          | 9.16±0.2ms           | 9.13±0.1ms          |    1    | stats.PearsonR.time_real                                                                    |
|          | 24.7±0.2M            | 24.3±1M             |    0.99 | stats.PearsonR.tracemalloc_lazy                                                             |
|          | 18.4±0.01M           | 18.4±0.01M          |    1    | stats.PearsonR.tracemalloc_real                                                             |
|          | 25.5±0.8ms           | 25.8±0.6ms          |    1.01 | trajectory.TrajectoryInterpolation.time_trajectory_linear                                   |
|          | 68.0±0.5ms           | 68.0±0.7ms          |    1    | trajectory.TrajectoryInterpolation.time_trajectory_nearest                                  |
|          | 23.3±0.01M           | 23.3±0.01M          |    1    | trajectory.TrajectoryInterpolation.tracemalloc_trajectory_linear                            |
|          | 12.1±0.04M           | 12.1±0.04M          |    1    | trajectory.TrajectoryInterpolation.tracemalloc_trajectory_nearest                           |

Generated by GHA run 12870849811

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants