-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Lazy median aggregator" #6293
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 869691f.
pp-mo
added
the
benchmark_this
Request that this pull request be benchmarked to check if it introduces performance shifts
label
Jan 20, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6293 +/- ##
=======================================
Coverage 89.85% 89.85%
=======================================
Files 88 88
Lines 23395 23387 -8
Branches 4358 4357 -1
=======================================
- Hits 21021 21014 -7
Misses 1646 1646
+ Partials 728 727 -1 ☔ View full report in Codecov by Sentry. |
⏱️ Performance Benchmark Report: 2c7d89fPerformance shifts
Full benchmark results
Generated by GHA run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
benchmark_this
Request that this pull request be benchmarked to check if it introduces performance shifts
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #6167