Skip to content

Commit

Permalink
Add https.blindly-trust-domains to Arcanist
Browse files Browse the repository at this point in the history
Summary:
This allows users to specify that they want to implicitly trust their weird self-signed certificate without verification.

This can either be specified per user (which will make it apply every time the user runs `arc`, in any project):

  arc set-config https.blindly-trust-domains '["example.mycompany.com"]'

...or added to a `.arcconfig` file (which will make it apply to every user who runs `arc` in that project):

  "https.blindly-trust-domains" : ["example.mycompany.com"]

Depends on D7130.

Test Plan: Tweaked config and verified this setting sends HTTPSFuture down the right branch.

Reviewers: btrahan

Reviewed By: btrahan

CC: hlau, aran

Differential Revision: https://secure.phabricator.com/D7131
  • Loading branch information
epriestley committed Sep 25, 2013
1 parent 0d0333d commit 6270dd0
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 0 deletions.
6 changes: 6 additions & 0 deletions scripts/arcanist.php
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,12 @@
HTTPSFuture::setGlobalCABundleFromPath($ca_bundle);
}

$blind_key = 'https.blindly-trust-domains';
$blind_trust = $working_copy->getConfigFromAnySource($blind_key);
if ($blind_trust) {
HTTPSFuture::setBlindlyTrustDomains($blind_trust);
}

if ($need_conduit) {
if (!$conduit_uri) {

Expand Down
6 changes: 6 additions & 0 deletions src/configuration/ArcanistSettings.php
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,12 @@ private function getOptions() {
"behind https signed by your organization's internal CA.",
'example' => 'support/yourca.pem'
),
'https.blindly-trust-domains' => array(
'type' => 'list',
'help' => 'List of domains to blindly trust SSL certificates for. '.
'Disables peer verification.',
'example' => '["secure.mycompany.com"]',
),
'browser' => array(
'type' => 'string',
'help' =>
Expand Down

0 comments on commit 6270dd0

Please sign in to comment.