Add prefix to IAM role

modules/ecs-cluster/main.tf

@@ -52,9 +52,10 @@ resource "aws_autoscaling_group" "this" {
   launch_configuration = aws_launch_configuration.this.name
   vpc_zone_identifier  = var.subnet_ids
 
-  min_size         = var.autoscaling_group.min_size
-  desired_capacity = var.autoscaling_group.desired_capacity
-  max_size         = var.autoscaling_group.max_size
+  min_size              = var.autoscaling_group.min_size
+  desired_capacity      = var.autoscaling_group.desired_capacity
+  max_size              = var.autoscaling_group.max_size
+  protect_from_scale_in = var.protect_from_scale_in
 
   placement_group      = aws_placement_group.this.id
   termination_policies = ["OldestInstance"]

modules/ecs-cluster/variables.tf

@@ -59,6 +59,12 @@ variable "ssm_tag_value" {
   default     = "true"
 }
 
+variable "protect_from_scale_in" {
+  type        = bool
+  description = "If protect from scale in is enabled, newly launched instances will be protected from scale in by default."
+  default     = false 
+}
+
 variable "ami" {
   type        = string
   description = "Image ID for Autoscaling group. If left blank, latest ECS-optimized version will be used."

modules/ecs-service/main.tf

@@ -7,6 +7,11 @@ locals {
   )}"
 }
 
+resource "random_id" "prefix" {
+  byte_length = 4
+  prefix      = "${var.name}-"
+}
+
 resource "aws_cloudwatch_log_group" "this" {
   name              = var.name
   retention_in_days = var.log_retention_in_days
@@ -101,7 +106,7 @@ resource "aws_ecs_service" "this" {
 }
 
 resource "aws_iam_role" "ecs" {
-  name               = "${var.name}-ecs-role"
+  name               = "${random_id.prefix.hex}-ecs"
   assume_role_policy = data.aws_iam_policy_document.ecs.json
 
   tags = var.tags