Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SemanticCite MW1.39 / SWM 4.0.0 compatible #116

Merged
merged 14 commits into from
Nov 20, 2023

Conversation

thomas-topway-it
Copy link
Contributor

Ensures SemanticCite is compatible with MW1.39 / SWM 4.0.0

Fixes the following:

  • remove reference to $GLOBALS
  • replace deprecated global function wfWikiID
  • remove obsolete onoi/http-request
  • replace Title's getNextRevisionID / getPreviousRevisionID in MediaWikiContextInteractor
  • replace deprecated global function wfReadOnly
  • updates MediaWikiContextInteractorTest

@krabina
Copy link
Contributor

krabina commented Oct 5, 2023

Fixes #110 and #107

@kizule
Copy link
Contributor

kizule commented Nov 20, 2023

Can we get this merged please? :)
@JeroenDeDauw

@krabina
Copy link
Contributor

krabina commented Nov 20, 2023

Did you try it out and can confirm it is working?
It is certainly working in our wikis.

@kizule
Copy link
Contributor

kizule commented Nov 20, 2023

Yes, I can. :)

@JeroenDeDauw JeroenDeDauw merged commit 27e2c23 into SemanticMediaWiki:master Nov 20, 2023
@z929669
Copy link

z929669 commented Nov 27, 2023

If compatibility issues should be resolved now for SMW ~4.0, then please update likewise at packagist.org. The current (outdated?) SMW constraint (mediawiki/semantic-media-wiki: ~3.0) forces me to use Semantic Cite dev-master as a workaround ... installing Semantic Media Wiki 4.1.2, and Composer complained that Semantic Cite 2.1 depends on SMW ~3.0.

@krabina
Copy link
Contributor

krabina commented Nov 27, 2023

@JeroenDeDauw I guess we need your help here. The PR seems to be working fine, but I don't know about the dependency topics also mentioned in #113

@krabina
Copy link
Contributor

krabina commented Nov 27, 2023

Oh. If I understand correctly this it more about making a new release so people don't have to use the dev-master, because #113 is solved already.

@z929669
Copy link

z929669 commented Nov 27, 2023

Oh. If I understand correctly this it more about making a new release so people don't have to use the dev-master, because #113 is solved already.

Yes, this is what I meant. I did go ahead and use dev-master with the latest merge of this patch, but I do still get the CACHE_ANYTHING error as described in #107 and #113

@JeroenDeDauw
Copy link
Member

Indeed, you need a new release

@JeroenDeDauw
Copy link
Member

Here is what to do: #118

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants