Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined constant warning #122

Closed
wants to merge 3 commits into from
Closed

Conversation

kizule
Copy link
Contributor

@kizule kizule commented Nov 28, 2023

Fixes #107 completely.

@kizule
Copy link
Contributor Author

kizule commented Nov 28, 2023

DNM, I'm testing this patch. At this moment, it's showing notice that caching-related constants are already defined in MediaWiki's includes/Defines.php file.

@kizule
Copy link
Contributor Author

kizule commented Nov 28, 2023

I don't guarantee that this is working fine at the moment, I'll test this further and cleanup the SemanticCite.php file.

@z929669
Copy link

z929669 commented Dec 6, 2023

Any confirmation yet if the "PHP Fatal error: Uncaught Error: Undefined constant "CACHE_ANYTHING"" issue is resolved and 3.0 release status? Thanks in advance for all you guys are doing ;)

@tsadrafoundation
Copy link

tsadrafoundation commented Jan 23, 2024

When (SemanticCite ~3.0) installed through composer it will throw a dependency error, and packages will not be installed. For now I'm using the dev-master and manually change CACHE_EVERYTHING to -1 in /var/www/html/extensions/SemanticCite/DefaultSettings.php

SMW 4.1, MW 1.39, PHP 8.1

@kizule kizule marked this pull request as draft February 7, 2024 08:20
@kizule
Copy link
Contributor Author

kizule commented Feb 7, 2024

I'm going to create a new PR.

@kizule kizule closed this Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not compatible with SWM 4.0.0
3 participants